cros: decouple show notification from OnAccessibilityStatusChanged

changes:
Decouples `show notification` from OnAccessibilityStatusChanged.
Callers decide to whether to show notification by explicitly notifying
observer themselves.

Bug: none
Test: tested on emulator, everything looks fine
Change-Id: If5cfbeaabea2583f7fe558cf098b69446a63bb14
Reviewed-on: https://chromium-review.googlesource.com/976091
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545881}

ash/accessibility/accessibility_controller.cc

@@ -318,10 +318,9 @@ void AccessibilityController::PlaySpokenFeedbackToggleCountdown(
     client_->PlaySpokenFeedbackToggleCountdown(tick_count);
 }
 
-void AccessibilityController::NotifyAccessibilityStatusChanged(
-    AccessibilityNotificationVisibility notify) {
+void AccessibilityController::NotifyAccessibilityStatusChanged() {
   for (auto& observer : observers_)
-    observer.OnAccessibilityStatusChanged(notify);
+    observer.OnAccessibilityStatusChanged();
 }
 
 void AccessibilityController::SetClient(
@@ -342,7 +341,8 @@ void AccessibilityController::BrailleDisplayStateChanged(bool connected) {
   braille_display_connected_ = connected;
   if (braille_display_connected_)
     SetSpokenFeedbackEnabled(true, A11Y_NOTIFICATION_SHOW);
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_SHOW);
+  NotifyAccessibilityStatusChanged();
+  NotifyShowAccessibilityNotification();
 }
 
 void AccessibilityController::SetFocusHighlightRect(
@@ -466,7 +466,7 @@ void AccessibilityController::UpdateAutoclickFromPref() {
 
   autoclick_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
 
   if (Shell::GetAshConfig() == Config::MASH) {
     if (!connector_)  // Null in tests.
@@ -511,7 +511,7 @@ void AccessibilityController::UpdateCaretHighlightFromPref() {
 
   caret_highlight_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
   UpdateAccessibilityHighlightingFromPrefs();
 }
 
@@ -525,7 +525,7 @@ void AccessibilityController::UpdateCursorHighlightFromPref() {
 
   cursor_highlight_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
   UpdateAccessibilityHighlightingFromPrefs();
 }
 
@@ -543,7 +543,7 @@ void AccessibilityController::UpdateFocusHighlightFromPref() {
 
   focus_highlight_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
   UpdateAccessibilityHighlightingFromPrefs();
 }
 
@@ -557,7 +557,7 @@ void AccessibilityController::UpdateHighContrastFromPref() {
 
   high_contrast_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
 
   // Under mash the UI service (window server) handles high contrast mode.
   if (Shell::GetAshConfig() == Config::MASH) {
@@ -589,7 +589,7 @@ void AccessibilityController::UpdateLargeCursorFromPref() {
   large_cursor_enabled_ = enabled;
   large_cursor_size_in_dip_ = size;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
 
   ShellPort::Get()->SetCursorSize(
       large_cursor_enabled_ ? ui::CursorSize::kLarge : ui::CursorSize::kNormal);
@@ -606,7 +606,7 @@ void AccessibilityController::UpdateMonoAudioFromPref() {
 
   mono_audio_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
   chromeos::CrasAudioHandler::Get()->SetOutputMonoEnabled(enabled);
 }
 
@@ -620,7 +620,10 @@ void AccessibilityController::UpdateSpokenFeedbackFromPref() {
 
   spoken_feedback_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(spoken_feedback_notification_);
+  NotifyAccessibilityStatusChanged();
+  if (spoken_feedback_notification_ != A11Y_NOTIFICATION_NONE)
+    NotifyShowAccessibilityNotification();
+
   // TODO(warx): ChromeVox loading/unloading requires browser process started,
   // thus it is still handled on Chrome side.
 
@@ -656,7 +659,7 @@ void AccessibilityController::UpdateSelectToSpeakFromPref() {
 
   select_to_speak_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
 }
 
 void AccessibilityController::UpdateStickyKeysFromPref() {
@@ -669,7 +672,7 @@ void AccessibilityController::UpdateStickyKeysFromPref() {
 
   sticky_keys_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
 
   Shell::Get()->sticky_keys_controller()->Enable(enabled);
 }
@@ -684,7 +687,7 @@ void AccessibilityController::UpdateVirtualKeyboardFromPref() {
 
   virtual_keyboard_enabled_ = enabled;
 
-  NotifyAccessibilityStatusChanged(A11Y_NOTIFICATION_NONE);
+  NotifyAccessibilityStatusChanged();
 
   keyboard::SetAccessibilityKeyboardEnabled(enabled);
 
@@ -706,4 +709,9 @@ void AccessibilityController::UpdateVirtualKeyboardFromPref() {
     Shell::Get()->DestroyKeyboard();
 }
 
+void AccessibilityController::NotifyShowAccessibilityNotification() {
+  for (auto& observer : observers_)
+    observer.ShowAccessibilityNotification();
+}
+
 }  // namespace ash

ash/accessibility/accessibility_controller.h

@@ -128,8 +128,7 @@ class ASH_EXPORT AccessibilityController
 
   // Public because a11y features like screen magnifier are managed outside of
   // this controller.
-  void NotifyAccessibilityStatusChanged(
-      AccessibilityNotificationVisibility notify);
+  void NotifyAccessibilityStatusChanged();
 
   // mojom::AccessibilityController:
   void SetClient(mojom::AccessibilityControllerClientPtr client) override;
@@ -164,6 +163,8 @@ class ASH_EXPORT AccessibilityController
   void UpdateVirtualKeyboardFromPref();
   void UpdateAccessibilityHighlightingFromPrefs();
 
+  void NotifyShowAccessibilityNotification();
+
   service_manager::Connector* connector_ = nullptr;
   std::unique_ptr<PrefChangeRegistrar> pref_change_registrar_;
 

ash/accessibility/accessibility_controller_unittest.cc

@@ -26,17 +26,9 @@ class TestAccessibilityObserver : public AccessibilityObserver {
   ~TestAccessibilityObserver() override = default;
 
   // AccessibilityObserver:
-  void OnAccessibilityStatusChanged(
-      AccessibilityNotificationVisibility notify) override {
-    if (notify == A11Y_NOTIFICATION_NONE) {
-      ++notification_none_changed_;
-    } else if (notify == A11Y_NOTIFICATION_SHOW) {
-      ++notification_show_changed_;
-    }
-  }
+  void OnAccessibilityStatusChanged() override { ++status_changed_count_; }
 
-  int notification_none_changed_ = 0;
-  int notification_show_changed_ = 0;
+  int status_changed_count_ = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestAccessibilityObserver);
@@ -101,15 +93,15 @@ TEST_F(AccessibilityControllerTest, SetAutoclickEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   controller->SetAutoclickEnabled(true);
   EXPECT_TRUE(controller->IsAutoclickEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetAutoclickEnabled(false);
   EXPECT_FALSE(controller->IsAutoclickEnabled());
-  EXPECT_EQ(2, observer.notification_none_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }
@@ -121,15 +113,15 @@ TEST_F(AccessibilityControllerTest, SetCaretHighlightEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   controller->SetCaretHighlightEnabled(true);
   EXPECT_TRUE(controller->IsCaretHighlightEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetCaretHighlightEnabled(false);
   EXPECT_FALSE(controller->IsCaretHighlightEnabled());
-  EXPECT_EQ(2, observer.notification_none_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }
@@ -141,15 +133,15 @@ TEST_F(AccessibilityControllerTest, SetCursorHighlightEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   controller->SetCursorHighlightEnabled(true);
   EXPECT_TRUE(controller->IsCursorHighlightEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetCursorHighlightEnabled(false);
   EXPECT_FALSE(controller->IsCursorHighlightEnabled());
-  EXPECT_EQ(2, observer.notification_none_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }
@@ -161,15 +153,15 @@ TEST_F(AccessibilityControllerTest, SetFocusHighlightEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   controller->SetFocusHighlightEnabled(true);
   EXPECT_TRUE(controller->IsFocusHighlightEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetFocusHighlightEnabled(false);
   EXPECT_FALSE(controller->IsFocusHighlightEnabled());
-  EXPECT_EQ(2, observer.notification_none_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }
@@ -181,15 +173,15 @@ TEST_F(AccessibilityControllerTest, SetHighContrastEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   controller->SetHighContrastEnabled(true);
   EXPECT_TRUE(controller->IsHighContrastEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetHighContrastEnabled(false);
   EXPECT_FALSE(controller->IsHighContrastEnabled());
-  EXPECT_EQ(2, observer.notification_none_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }
@@ -201,15 +193,15 @@ TEST_F(AccessibilityControllerTest, SetLargeCursorEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   controller->SetLargeCursorEnabled(true);
   EXPECT_TRUE(controller->IsLargeCursorEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetLargeCursorEnabled(false);
   EXPECT_FALSE(controller->IsLargeCursorEnabled());
-  EXPECT_EQ(2, observer.notification_none_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }
@@ -238,15 +230,15 @@ TEST_F(AccessibilityControllerTest, SetMonoAudioEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   controller->SetMonoAudioEnabled(true);
   EXPECT_TRUE(controller->IsMonoAudioEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetMonoAudioEnabled(false);
   EXPECT_FALSE(controller->IsMonoAudioEnabled());
-  EXPECT_EQ(2, observer.notification_none_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }
@@ -258,18 +250,15 @@ TEST_F(AccessibilityControllerTest, SetSpokenFeedbackEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
-  EXPECT_EQ(0, observer.notification_show_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   controller->SetSpokenFeedbackEnabled(true, A11Y_NOTIFICATION_SHOW);
   EXPECT_TRUE(controller->IsSpokenFeedbackEnabled());
-  EXPECT_EQ(0, observer.notification_none_changed_);
-  EXPECT_EQ(1, observer.notification_show_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetSpokenFeedbackEnabled(false, A11Y_NOTIFICATION_NONE);
   EXPECT_FALSE(controller->IsSpokenFeedbackEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
-  EXPECT_EQ(1, observer.notification_show_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }
@@ -281,19 +270,19 @@ TEST_F(AccessibilityControllerTest, SetStickyKeysEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   StickyKeysController* sticky_keys_controller =
       Shell::Get()->sticky_keys_controller();
   controller->SetStickyKeysEnabled(true);
   EXPECT_TRUE(sticky_keys_controller->enabled_for_test());
   EXPECT_TRUE(controller->IsStickyKeysEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetStickyKeysEnabled(false);
   EXPECT_FALSE(sticky_keys_controller->enabled_for_test());
   EXPECT_FALSE(controller->IsStickyKeysEnabled());
-  EXPECT_EQ(2, observer.notification_none_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }
@@ -305,17 +294,17 @@ TEST_F(AccessibilityControllerTest, SetVirtualKeyboardEnabled) {
 
   TestAccessibilityObserver observer;
   controller->AddObserver(&observer);
-  EXPECT_EQ(0, observer.notification_none_changed_);
+  EXPECT_EQ(0, observer.status_changed_count_);
 
   controller->SetVirtualKeyboardEnabled(true);
   EXPECT_TRUE(keyboard::GetAccessibilityKeyboardEnabled());
   EXPECT_TRUE(controller->IsVirtualKeyboardEnabled());
-  EXPECT_EQ(1, observer.notification_none_changed_);
+  EXPECT_EQ(1, observer.status_changed_count_);
 
   controller->SetVirtualKeyboardEnabled(false);
   EXPECT_FALSE(keyboard::GetAccessibilityKeyboardEnabled());
   EXPECT_FALSE(controller->IsVirtualKeyboardEnabled());
-  EXPECT_EQ(2, observer.notification_none_changed_);
+  EXPECT_EQ(2, observer.status_changed_count_);
 
   controller->RemoveObserver(&observer);
 }

ash/accessibility/accessibility_observer.h

@@ -6,7 +6,6 @@
 #define ASH_ACCESSIBILITY_ACCESSIBILITY_OBSERVER_H_
 
 #include "ash/ash_export.h"
-#include "ash/public/cpp/accessibility_types.h"
 
 namespace ash {
 
@@ -14,12 +13,13 @@ class ASH_EXPORT AccessibilityObserver {
  public:
   virtual ~AccessibilityObserver() {}
 
-  // Notifies when accessibility status changes. Used to:
-  // * Show the accessibility menu when any feature is enabled.
-  // * Show notifications when spoken feedback or braille is enabled.
-  // TODO(jamescook): Split into two methods.
-  virtual void OnAccessibilityStatusChanged(
-      AccessibilityNotificationVisibility notify) = 0;
+  // Called when any accessibility status changes.
+  virtual void OnAccessibilityStatusChanged() {}
+
+  // Called when notification should be shown for accessibility status changes,
+  // used for spoken feedback or braille is enabled.
+  // TODO(warx): move this to AccessibilityController.
+  virtual void ShowAccessibilityNotification() {}
 };
 
 }  // namespace ash

ash/accessibility/touch_exploration_manager.cc

@@ -56,8 +56,7 @@ TouchExplorationManager::~TouchExplorationManager() {
   Shell::Get()->RemoveShellObserver(this);
 }
 
-void TouchExplorationManager::OnAccessibilityStatusChanged(
-    AccessibilityNotificationVisibility notify) {
+void TouchExplorationManager::OnAccessibilityStatusChanged() {
   UpdateTouchExplorationState();
 }
 

ash/accessibility/touch_exploration_manager.h

@@ -50,8 +50,7 @@ class ASH_EXPORT TouchExplorationManager
   ~TouchExplorationManager() override;
 
   // AccessibilityObserver overrides:
-  void OnAccessibilityStatusChanged(
-      AccessibilityNotificationVisibility notify) override;
+  void OnAccessibilityStatusChanged() override;
 
   // TouchExplorationControllerDelegate overrides:
   void SetOutputLevel(int volume) override;

ash/keyboard/keyboard_ui.cc

@@ -10,8 +10,6 @@
 #include "ash/accessibility/accessibility_observer.h"
 #include "ash/keyboard/keyboard_ui_observer.h"
 #include "ash/shell.h"
-#include "ash/system/tray/system_tray_notifier.h"
-#include "ash/system/tray_accessibility.h"
 #include "ui/keyboard/keyboard_controller.h"
 
 namespace ash {
@@ -44,8 +42,7 @@ class KeyboardUIImpl : public KeyboardUI, public AccessibilityObserver {
   }
 
   // AccessibilityObserver:
-  void OnAccessibilityStatusChanged(
-      AccessibilityNotificationVisibility notify) override {
+  void OnAccessibilityStatusChanged() override {
     bool enabled = IsEnabled();
     if (enabled_ == enabled)
       return;

ash/magnifier/docked_magnifier_controller.cc

@@ -523,8 +523,7 @@ void DockedMagnifierController::OnEnabledPrefChanged() {
 
   // Update the green checkmark status in the accessibility menu in the system
   // tray.
-  shell->accessibility_controller()->NotifyAccessibilityStatusChanged(
-      A11Y_NOTIFICATION_NONE);
+  shell->accessibility_controller()->NotifyAccessibilityStatusChanged();
 
   // We use software composited mouse cursor so that it can be mirrored into the
   // magnifier viewport.

ash/system/ime/tray_ime_chromeos.cc

@@ -175,8 +175,7 @@ void TrayIME::OnKeyboardSuppressionChanged(bool suppressed) {
   Update();
 }
 
-void TrayIME::OnAccessibilityStatusChanged(
-    AccessibilityNotificationVisibility notify) {
+void TrayIME::OnAccessibilityStatusChanged() {
   Update();
 }
 

ash/system/ime/tray_ime_chromeos.h

@@ -40,8 +40,7 @@ class ASH_EXPORT TrayIME : public SystemTrayItem,
   void OnKeyboardSuppressionChanged(bool suppressed) override;
 
   // Overridden from AccessibilityObserver:
-  void OnAccessibilityStatusChanged(
-      AccessibilityNotificationVisibility notify) override;
+  void OnAccessibilityStatusChanged() override;
 
  private:
   friend class TrayIMETest;

ash/system/tray_accessibility.cc

@@ -531,10 +531,15 @@ void TrayAccessibility::UpdateAfterLoginStatusChange(LoginStatus status) {
   SetTrayIconVisible(GetInitialVisibility());
 }
 
-void TrayAccessibility::OnAccessibilityStatusChanged(
-    AccessibilityNotificationVisibility notify) {
+void TrayAccessibility::OnAccessibilityStatusChanged() {
   SetTrayIconVisible(GetInitialVisibility());
 
+  if (detailed_menu_)
+    detailed_menu_->OnAccessibilityStatusChanged();
+}
+
+// TODO(warx): Move ShowAccessibilityNotification() to AccessibilityController.
+void TrayAccessibility::ShowAccessibilityNotification() {
   uint32_t accessibility_state = GetAccessibilityState();
   // We'll get an extra notification if a braille display is connected when
   // spoken feedback wasn't already enabled.  This is because the braille
@@ -544,9 +549,6 @@ void TrayAccessibility::OnAccessibilityStatusChanged(
   if (accessibility_state == previous_accessibility_state_)
     return;
 
-  if (detailed_menu_)
-    detailed_menu_->OnAccessibilityStatusChanged();
-
   message_center::MessageCenter* message_center =
       message_center::MessageCenter::Get();
   message_center->RemoveNotification(kNotificationId, false /* by_user */);
@@ -558,9 +560,7 @@ void TrayAccessibility::OnAccessibilityStatusChanged(
       (A11Y_SPOKEN_FEEDBACK | A11Y_BRAILLE_DISPLAY_CONNECTED);
   previous_accessibility_state_ = accessibility_state;
 
-  // Shows notification if |notify| is true and the spoken feedback is being
-  // enabled or if a braille display is connected.
-  if (notify != A11Y_NOTIFICATION_SHOW || being_enabled == A11Y_NONE)
+  if (being_enabled == A11Y_NONE)
     return;
 
   base::string16 text;

ash/system/tray_accessibility.h

@@ -122,8 +122,8 @@ class TrayAccessibility : public TrayImageItem, public AccessibilityObserver {
   void UpdateAfterLoginStatusChange(LoginStatus status) override;
 
   // Overridden from AccessibilityObserver.
-  void OnAccessibilityStatusChanged(
-      AccessibilityNotificationVisibility notify) override;
+  void OnAccessibilityStatusChanged() override;
+  void ShowAccessibilityNotification() override;
 
   views::View* default_;
   tray::AccessibilityDetailedView* detailed_menu_;

ash/wm/workspace/backdrop_controller.cc

@@ -164,8 +164,7 @@ void BackdropController::OnSplitViewModeEnded() {
   Shell::Get()->split_view_controller()->RemoveObserver(this);
 }
 
-void BackdropController::OnAccessibilityStatusChanged(
-    AccessibilityNotificationVisibility notify) {
+void BackdropController::OnAccessibilityStatusChanged() {
   UpdateBackdrop();
 }
 

ash/wm/workspace/backdrop_controller.h

@@ -71,8 +71,7 @@ class BackdropController : public ShellObserver,
   void OnSplitViewModeEnded() override;
 
   // AccessibilityObserver:
-  void OnAccessibilityStatusChanged(
-      AccessibilityNotificationVisibility notify) override;
+  void OnAccessibilityStatusChanged() override;
 
   // SplitViewController::Observer:
   void OnSplitViewStateChanged(SplitViewController::State previous_state,

chrome/browser/chromeos/accessibility/accessibility_manager.cc

@@ -378,7 +378,7 @@ void AccessibilityManager::UpdateAlwaysShowMenuFromPref() {
   // Update system tray menu visibility.
   ash::Shell::Get()
       ->accessibility_controller()
-      ->NotifyAccessibilityStatusChanged(ash::A11Y_NOTIFICATION_NONE);
+      ->NotifyAccessibilityStatusChanged();
 }
 
 void AccessibilityManager::EnableLargeCursor(bool enabled) {
@@ -1070,7 +1070,7 @@ void AccessibilityManager::NotifyAccessibilityStatusChanged(
   if (details.notification_type == ACCESSIBILITY_TOGGLE_SCREEN_MAGNIFIER) {
     ash::Shell::Get()
         ->accessibility_controller()
-        ->NotifyAccessibilityStatusChanged(details.notify);
+        ->NotifyAccessibilityStatusChanged();
   }
 }