Commit 9c44fedd authored by Eric Karl's avatar Eric Karl Committed by Commit Bot

Cleanup Android video targets

Fixes WebView component build issues.

Previous CLs introduced a number of new targets including
texture_owner_android and shared_image_video. These were causing build
problems due to duplicate file compilation which led to DCHECKs.

Moved most of these files into gpu/command_buffer/service:gles2, as
they all depended on this target (so no new transitive deps), and it's
probably a good place for them for now and simplifies dependency
management.

Bug: 996285
Change-Id: Ic5a9cced7e67500cfd5fff8809d4ee5e17bbab8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787165Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
Reviewed-by: default avatarvikas soni <vikassoni@chromium.org>
Auto-Submit: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695006}
parent 5be135fc
...@@ -18,8 +18,8 @@ ...@@ -18,8 +18,8 @@
#include "content/public/android/content_jni_headers/ContentChildProcessServiceDelegate_jni.h" #include "content/public/android/content_jni_headers/ContentChildProcessServiceDelegate_jni.h"
#include "content/public/common/content_descriptors.h" #include "content/public/common/content_descriptors.h"
#include "content/public/common/content_switches.h" #include "content/public/common/content_switches.h"
#include "gpu/command_buffer/service/texture_owner.h"
#include "gpu/ipc/common/android/scoped_surface_request_conduit.h" #include "gpu/ipc/common/android/scoped_surface_request_conduit.h"
#include "gpu/ipc/common/android/texture_owner.h"
#include "gpu/ipc/common/gpu_surface_lookup.h" #include "gpu/ipc/common/gpu_surface_lookup.h"
#include "services/service_manager/embedder/shared_file_util.h" #include "services/service_manager/embedder/shared_file_util.h"
#include "services/service_manager/embedder/switches.h" #include "services/service_manager/embedder/switches.h"
......
...@@ -2415,7 +2415,7 @@ jumbo_source_set("browser") { ...@@ -2415,7 +2415,7 @@ jumbo_source_set("browser") {
"//build/config/freetype", "//build/config/freetype",
"//content/public/android:jni", "//content/public/android:jni",
"//device/gamepad/public/mojom", "//device/gamepad/public/mojom",
"//gpu/ipc/common:android_texture_owner", "//gpu/command_buffer/service:gles2",
"//media", "//media",
"//media/capture/content/android", "//media/capture/content/android",
"//media/capture/video/android", "//media/capture/video/android",
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
#include "base/task/post_task.h" #include "base/task/post_task.h"
#include "content/public/browser/browser_task_traits.h" #include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h" #include "content/public/browser/browser_thread.h"
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
namespace content { namespace content {
......
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
#include "base/callback_forward.h" #include "base/callback_forward.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "content/public/test/browser_task_environment.h" #include "content/public/test/browser_task_environment.h"
#include "gpu/ipc/common/android/mock_texture_owner.h" #include "gpu/command_buffer/service/mock_texture_owner.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "ui/gl/android/scoped_java_surface.h" #include "ui/gl/android/scoped_java_surface.h"
#include "ui/gl/android/surface_texture.h" #include "ui/gl/android/surface_texture.h"
......
...@@ -2270,7 +2270,7 @@ test("content_unittests") { ...@@ -2270,7 +2270,7 @@ test("content_unittests") {
"//build/config/freetype", "//build/config/freetype",
"//components/download/internal/common:internal_java", "//components/download/internal/common:internal_java",
"//content/public/android:content_java", "//content/public/android:content_java",
"//gpu/ipc/common:android_texture_owner_test_support", "//gpu/command_buffer/service:android_texture_owner_test_support",
"//media/capture/content/android", "//media/capture/content/android",
"//media/capture/content/android:screen_capture_java", "//media/capture/content/android:screen_capture_java",
"//third_party/blink/public/common", "//third_party/blink/public/common",
......
...@@ -382,9 +382,17 @@ target(link_target_type, "gles2_sources") { ...@@ -382,9 +382,17 @@ target(link_target_type, "gles2_sources") {
sources += [ sources += [
"ahardwarebuffer_utils.cc", "ahardwarebuffer_utils.cc",
"ahardwarebuffer_utils.h", "ahardwarebuffer_utils.h",
"image_reader_gl_owner.cc",
"image_reader_gl_owner.h",
"shared_image_backing_factory_ahardwarebuffer.cc", "shared_image_backing_factory_ahardwarebuffer.cc",
"shared_image_backing_factory_ahardwarebuffer.h", "shared_image_backing_factory_ahardwarebuffer.h",
"shared_image_video.cc",
"shared_image_video.h",
"stream_texture_shared_image_interface.h", "stream_texture_shared_image_interface.h",
"surface_texture_gl_owner.cc",
"surface_texture_gl_owner.h",
"texture_owner.cc",
"texture_owner.h",
] ]
# TODO(cblume): http://crbug.com/911313 # TODO(cblume): http://crbug.com/911313
...@@ -409,36 +417,51 @@ target(link_target_type, "gles2_sources") { ...@@ -409,36 +417,51 @@ target(link_target_type, "gles2_sources") {
} }
} }
proto_library("disk_cache_proto") {
sources = [
"disk_cache_proto.proto",
]
}
if (is_android) { if (is_android) {
component("shared_image_video") { jumbo_static_library("android_texture_owner_test_support") {
testonly = true
sources = [ sources = [
"shared_image_video.cc", "mock_abstract_texture.cc",
"shared_image_video.h", "mock_abstract_texture.h",
"mock_texture_owner.cc",
"mock_texture_owner.h",
] ]
configs += [ "//gpu:gpu_gles2_implementation" ]
deps = [ deps = [
"//base", ":gles2",
"//components/viz/common:resource_format_utils", "//base/test:test_support",
"//components/viz/common:vulkan_context_provider", "//gpu:test_support",
"//gpu/command_buffer/service:gles2_sources", "//testing/gmock",
"//gpu/command_buffer/service:service_sources", "//testing/gtest",
"//gpu/ipc/common:android_texture_owner",
"//gpu/ipc/common:common",
"//ui/gl", "//ui/gl",
] "//ui/gl/init",
if (enable_vulkan) {
deps += [ "//gpu/vulkan:vulkan" ]
}
visibility = [
"//gpu/*",
"//media/gpu:gpu",
] ]
} }
} }
proto_library("disk_cache_proto") { if (is_android) {
sources = [ source_set("android_texture_owner_unittests") {
"disk_cache_proto.proto", testonly = true
] sources = [
"image_reader_gl_owner_unittest.cc",
"surface_texture_gl_owner_unittest.cc",
]
deps = [
":android_texture_owner_test_support",
":gles2",
"//base/test:test_support",
"//gpu:test_support",
"//media/base:base",
"//testing/gmock",
"//testing/gtest",
"//ui/gl",
"//ui/gl/init",
]
}
} }
...@@ -8,3 +8,9 @@ include_rules = [ ...@@ -8,3 +8,9 @@ include_rules = [
"+components/viz/common/resources/resource_format_utils.h", "+components/viz/common/resources/resource_format_utils.h",
"+components/viz/common/resources/resource_sizes.h", "+components/viz/common/resources/resource_sizes.h",
] ]
specific_include_rules = {
"image_reader_gl_owner_unittest.cc": [
"+media/base/media_switches.h",
],
}
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "gpu/ipc/common/android/image_reader_gl_owner.h" #include "gpu/command_buffer/service/image_reader_gl_owner.h"
#include <android/native_window_jni.h> #include <android/native_window_jni.h>
#include <jni.h> #include <jni.h>
......
...@@ -2,14 +2,15 @@ ...@@ -2,14 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef GPU_IPC_COMMON_ANDROID_IMAGE_READER_GL_OWNER_H_ #ifndef GPU_COMMAND_BUFFER_SERVICE_IMAGE_READER_GL_OWNER_H_
#define GPU_IPC_COMMON_ANDROID_IMAGE_READER_GL_OWNER_H_ #define GPU_COMMAND_BUFFER_SERVICE_IMAGE_READER_GL_OWNER_H_
#include <memory> #include <memory>
#include "base/android/android_image_reader_compat.h" #include "base/android/android_image_reader_compat.h"
#include "base/containers/flat_map.h" #include "base/containers/flat_map.h"
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include "gpu/gpu_gles2_export.h"
#include "ui/gl/gl_fence_egl.h" #include "ui/gl/gl_fence_egl.h"
#include "ui/gl/gl_image_ahardwarebuffer.h" #include "ui/gl/gl_image_ahardwarebuffer.h"
...@@ -27,7 +28,7 @@ namespace gpu { ...@@ -27,7 +28,7 @@ namespace gpu {
// decoded media frames. Media frames can update the attached surface handle // decoded media frames. Media frames can update the attached surface handle
// with image data and this class helps to create an eglImage using that image // with image data and this class helps to create an eglImage using that image
// data present in the surface. // data present in the surface.
class GPU_EXPORT ImageReaderGLOwner : public TextureOwner { class GPU_GLES2_EXPORT ImageReaderGLOwner : public TextureOwner {
public: public:
gl::GLContext* GetContext() const override; gl::GLContext* GetContext() const override;
gl::GLSurface* GetSurface() const override; gl::GLSurface* GetSurface() const override;
...@@ -132,4 +133,4 @@ class GPU_EXPORT ImageReaderGLOwner : public TextureOwner { ...@@ -132,4 +133,4 @@ class GPU_EXPORT ImageReaderGLOwner : public TextureOwner {
} // namespace gpu } // namespace gpu
#endif // GPU_IPC_COMMON_ANDROID_IMAGE_READER_GL_OWNER_H_ #endif // GPU_COMMAND_BUFFER_SERVICE_IMAGE_READER_GL_OWNER_H_
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include <stdint.h> #include <stdint.h>
#include <memory> #include <memory>
...@@ -11,8 +11,8 @@ ...@@ -11,8 +11,8 @@
#include "base/test/scoped_feature_list.h" #include "base/test/scoped_feature_list.h"
#include "base/test/task_environment.h" #include "base/test/task_environment.h"
#include "gpu/command_buffer/service/abstract_texture.h" #include "gpu/command_buffer/service/abstract_texture.h"
#include "gpu/ipc/common/android/image_reader_gl_owner.h" #include "gpu/command_buffer/service/image_reader_gl_owner.h"
#include "gpu/ipc/common/android/mock_abstract_texture.h" #include "gpu/command_buffer/service/mock_abstract_texture.h"
#include "media/base/media_switches.h" #include "media/base/media_switches.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "ui/gl/gl_bindings.h" #include "ui/gl/gl_bindings.h"
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "gpu/ipc/common/android/mock_abstract_texture.h" #include "gpu/command_buffer/service/mock_abstract_texture.h"
namespace gpu { namespace gpu {
......
...@@ -2,8 +2,8 @@ ...@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef GPU_IPC_COMMON_ANDROID_MOCK_ABSTRACT_TEXTURE_H_ #ifndef GPU_COMMAND_BUFFER_SERVICE_MOCK_ABSTRACT_TEXTURE_H_
#define GPU_IPC_COMMON_ANDROID_MOCK_ABSTRACT_TEXTURE_H_ #define GPU_COMMAND_BUFFER_SERVICE_MOCK_ABSTRACT_TEXTURE_H_
#include "base/memory/weak_ptr.h" #include "base/memory/weak_ptr.h"
#include "gpu/command_buffer/service/abstract_texture.h" #include "gpu/command_buffer/service/abstract_texture.h"
...@@ -42,4 +42,4 @@ class MockAbstractTexture ...@@ -42,4 +42,4 @@ class MockAbstractTexture
} // namespace gpu } // namespace gpu
#endif // GPU_IPC_COMMON_ANDROID_MOCK_ABSTRACT_TEXTURE_H_ #endif // GPU_COMMAND_BUFFER_SERVICE_MOCK_ABSTRACT_TEXTURE_H_
...@@ -2,9 +2,9 @@ ...@@ -2,9 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "gpu/ipc/common/android/mock_texture_owner.h" #include "gpu/command_buffer/service/mock_texture_owner.h"
#include "gpu/ipc/common/android/mock_abstract_texture.h" #include "gpu/command_buffer/service/mock_abstract_texture.h"
namespace gpu { namespace gpu {
......
...@@ -2,13 +2,13 @@ ...@@ -2,13 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef GPU_IPC_COMMON_ANDROID_MOCK_TEXTURE_OWNER_H_ #ifndef GPU_COMMAND_BUFFER_SERVICE_MOCK_TEXTURE_OWNER_H_
#define GPU_IPC_COMMON_ANDROID_MOCK_TEXTURE_OWNER_H_ #define GPU_COMMAND_BUFFER_SERVICE_MOCK_TEXTURE_OWNER_H_
#include <memory> #include <memory>
#include "base/android/scoped_hardware_buffer_fence_sync.h" #include "base/android/scoped_hardware_buffer_fence_sync.h"
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include "testing/gmock/include/gmock/gmock.h" #include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "ui/gl/gl_bindings.h" #include "ui/gl/gl_bindings.h"
...@@ -55,4 +55,4 @@ class MockTextureOwner : public TextureOwner { ...@@ -55,4 +55,4 @@ class MockTextureOwner : public TextureOwner {
} // namespace gpu } // namespace gpu
#endif // GPU_IPC_COMMON_ANDROID_MOCK_TEXTURE_OWNER_H_ #endif // GPU_COMMAND_BUFFER_SERVICE_MOCK_TEXTURE_OWNER_H_
...@@ -20,7 +20,7 @@ ...@@ -20,7 +20,7 @@
#include "gpu/command_buffer/service/shared_image_representation_skia_gl.h" #include "gpu/command_buffer/service/shared_image_representation_skia_gl.h"
#include "gpu/command_buffer/service/skia_utils.h" #include "gpu/command_buffer/service/skia_utils.h"
#include "gpu/command_buffer/service/texture_manager.h" #include "gpu/command_buffer/service/texture_manager.h"
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include "gpu/vulkan/vulkan_device_queue.h" #include "gpu/vulkan/vulkan_device_queue.h"
#include "gpu/vulkan/vulkan_fence_helper.h" #include "gpu/vulkan/vulkan_fence_helper.h"
#include "gpu/vulkan/vulkan_function_pointers.h" #include "gpu/vulkan/vulkan_function_pointers.h"
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "gpu/ipc/common/android/surface_texture_gl_owner.h" #include "gpu/command_buffer/service/surface_texture_gl_owner.h"
#include <memory> #include <memory>
......
...@@ -2,12 +2,12 @@ ...@@ -2,12 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef GPU_IPC_COMMON_ANDROID_SURFACE_TEXTURE_GL_OWNER_H_ #ifndef GPU_COMMAND_BUFFER_SERVICE_SURFACE_TEXTURE_GL_OWNER_H_
#define GPU_IPC_COMMON_ANDROID_SURFACE_TEXTURE_GL_OWNER_H_ #define GPU_COMMAND_BUFFER_SERVICE_SURFACE_TEXTURE_GL_OWNER_H_
#include "base/threading/thread_checker.h" #include "base/threading/thread_checker.h"
#include "gpu/command_buffer/service/texture_owner.h"
#include "gpu/gpu_export.h" #include "gpu/gpu_export.h"
#include "gpu/ipc/common/android/texture_owner.h"
#include "ui/gl/android/surface_texture.h" #include "ui/gl/android/surface_texture.h"
namespace base { namespace base {
...@@ -62,4 +62,4 @@ class GPU_EXPORT SurfaceTextureGLOwner : public TextureOwner { ...@@ -62,4 +62,4 @@ class GPU_EXPORT SurfaceTextureGLOwner : public TextureOwner {
} // namespace gpu } // namespace gpu
#endif // GPU_IPC_COMMON_ANDROID_SURFACE_TEXTURE_GL_OWNER_H_ #endif // GPU_COMMAND_BUFFER_SERVICE_SURFACE_TEXTURE_GL_OWNER_H_
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "gpu/ipc/common/android/surface_texture_gl_owner.h" #include "gpu/command_buffer/service/surface_texture_gl_owner.h"
#include <stdint.h> #include <stdint.h>
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/logging.h" #include "base/logging.h"
#include "base/test/task_environment.h" #include "base/test/task_environment.h"
#include "gpu/ipc/common/android/mock_abstract_texture.h" #include "gpu/command_buffer/service/mock_abstract_texture.h"
#include "testing/gmock/include/gmock/gmock.h" #include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h" #include "testing/gtest/include/gtest/gtest.h"
#include "ui/gl/gl_bindings.h" #include "ui/gl/gl_bindings.h"
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include <memory> #include <memory>
...@@ -13,9 +13,9 @@ ...@@ -13,9 +13,9 @@
#include "gpu/command_buffer/service/abstract_texture_impl_shared_context_state.h" #include "gpu/command_buffer/service/abstract_texture_impl_shared_context_state.h"
#include "gpu/command_buffer/service/decoder_context.h" #include "gpu/command_buffer/service/decoder_context.h"
#include "gpu/command_buffer/service/feature_info.h" #include "gpu/command_buffer/service/feature_info.h"
#include "gpu/command_buffer/service/image_reader_gl_owner.h"
#include "gpu/command_buffer/service/surface_texture_gl_owner.h"
#include "gpu/command_buffer/service/texture_base.h" #include "gpu/command_buffer/service/texture_base.h"
#include "gpu/ipc/common/android/image_reader_gl_owner.h"
#include "gpu/ipc/common/android/surface_texture_gl_owner.h"
#include "ui/gl/scoped_binders.h" #include "ui/gl/scoped_binders.h"
namespace gpu { namespace gpu {
......
...@@ -2,15 +2,15 @@ ...@@ -2,15 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
#ifndef GPU_IPC_COMMON_ANDROID_TEXTURE_OWNER_H_ #ifndef GPU_COMMAND_BUFFER_SERVICE_TEXTURE_OWNER_H_
#define GPU_IPC_COMMON_ANDROID_TEXTURE_OWNER_H_ #define GPU_COMMAND_BUFFER_SERVICE_TEXTURE_OWNER_H_
#include <android/hardware_buffer.h> #include <android/hardware_buffer.h>
#include "base/memory/ref_counted.h" #include "base/memory/ref_counted.h"
#include "base/memory/ref_counted_delete_on_sequence.h" #include "base/memory/ref_counted_delete_on_sequence.h"
#include "base/single_thread_task_runner.h" #include "base/single_thread_task_runner.h"
#include "gpu/gpu_export.h" #include "gpu/gpu_gles2_export.h"
#include "ui/gl/android/scoped_java_surface.h" #include "ui/gl/android/scoped_java_surface.h"
#include "ui/gl/gl_bindings.h" #include "ui/gl/gl_bindings.h"
#include "ui/gl/gl_context.h" #include "ui/gl/gl_context.h"
...@@ -37,7 +37,7 @@ class AbstractTexture; ...@@ -37,7 +37,7 @@ class AbstractTexture;
// be called on any thread. It's safe to keep and drop refptrs to it on any // be called on any thread. It's safe to keep and drop refptrs to it on any
// thread; it will be automatically destructed on the thread it was constructed // thread; it will be automatically destructed on the thread it was constructed
// on. // on.
class GPU_EXPORT TextureOwner class GPU_GLES2_EXPORT TextureOwner
: public base::RefCountedDeleteOnSequence<TextureOwner> { : public base::RefCountedDeleteOnSequence<TextureOwner> {
public: public:
// Creates a GL texture using the current platform GL context and returns a // Creates a GL texture using the current platform GL context and returns a
...@@ -136,4 +136,4 @@ class GPU_EXPORT TextureOwner ...@@ -136,4 +136,4 @@ class GPU_EXPORT TextureOwner
} // namespace gpu } // namespace gpu
#endif // GPU_IPC_COMMON_ANDROID_TEXTURE_OWNER_H_ #endif // GPU_COMMAND_BUFFER_SERVICE_TEXTURE_OWNER_H_
...@@ -142,6 +142,8 @@ source_set("ipc_common_sources") { ...@@ -142,6 +142,8 @@ source_set("ipc_common_sources") {
if (is_android) { if (is_android) {
sources += [ sources += [
"android/scoped_surface_request_conduit.cc",
"android/scoped_surface_request_conduit.h",
"gpu_surface_lookup.cc", "gpu_surface_lookup.cc",
"gpu_surface_lookup.h", "gpu_surface_lookup.h",
"gpu_surface_tracker.cc", "gpu_surface_tracker.cc",
...@@ -173,78 +175,6 @@ if (is_android) { ...@@ -173,78 +175,6 @@ if (is_android) {
} }
} }
if (is_android) {
component("android_texture_owner") {
sources = [
"android/image_reader_gl_owner.cc",
"android/image_reader_gl_owner.h",
"android/scoped_surface_request_conduit.cc",
"android/scoped_surface_request_conduit.h",
"android/surface_texture_gl_owner.cc",
"android/surface_texture_gl_owner.h",
"android/texture_owner.cc",
"android/texture_owner.h",
]
configs += [ "//gpu:gpu_implementation" ]
deps = [
":android_image_reader_utils",
"//base",
"//gpu/command_buffer/service:gles2_sources",
"//gpu/command_buffer/service:service_sources",
"//ui/gl",
]
libs = [ "android" ]
visibility = [
"//gpu/*",
"//media/gpu:gpu",
"//content/browser:browser",
]
}
}
if (is_android) {
jumbo_static_library("android_texture_owner_test_support") {
testonly = true
sources = [
"android/mock_abstract_texture.cc",
"android/mock_abstract_texture.h",
"android/mock_texture_owner.cc",
"android/mock_texture_owner.h",
]
deps = [
":android_texture_owner",
"//base/test:test_support",
"//gpu:test_support",
"//testing/gmock",
"//testing/gtest",
"//ui/gl",
"//ui/gl/init",
]
}
}
if (is_android) {
source_set("android_texture_owner_unittests") {
testonly = true
sources = [
"android/image_reader_gl_owner_unittest.cc",
"android/surface_texture_gl_owner_unittest.cc",
]
deps = [
":android_texture_owner",
":android_texture_owner_test_support",
"//base/test:test_support",
"//gpu:test_support",
"//media/base:base",
"//testing/gmock",
"//testing/gtest",
"//ui/gl",
"//ui/gl/init",
]
}
}
# Depend on this to use surface_handle.h without pulling in all of gpu ipc. # Depend on this to use surface_handle.h without pulling in all of gpu ipc.
source_set("surface_handle_type") { source_set("surface_handle_type") {
public = [ public = [
......
...@@ -5,5 +5,4 @@ include_rules = [ ...@@ -5,5 +5,4 @@ include_rules = [
"+mojo", "+mojo",
"+ui/base", "+ui/base",
"+ui/latency", "+ui/latency",
"+media/base/media_switches.h",
] ]
...@@ -115,10 +115,6 @@ jumbo_component("service") { ...@@ -115,10 +115,6 @@ jumbo_component("service") {
"stream_texture_android.h", "stream_texture_android.h",
] ]
libs += [ "android" ] libs += [ "android" ]
deps += [
"//gpu/command_buffer/service:shared_image_video",
"//gpu/ipc/common:android_texture_owner",
]
} }
if (is_linux) { if (is_linux) {
sources += [ "image_transport_surface_linux.cc" ] sources += [ "image_transport_surface_linux.cc" ]
......
...@@ -16,7 +16,7 @@ ...@@ -16,7 +16,7 @@
#include "gpu/command_buffer/service/gl_stream_texture_image.h" #include "gpu/command_buffer/service/gl_stream_texture_image.h"
#include "gpu/command_buffer/service/shared_context_state.h" #include "gpu/command_buffer/service/shared_context_state.h"
#include "gpu/command_buffer/service/stream_texture_shared_image_interface.h" #include "gpu/command_buffer/service/stream_texture_shared_image_interface.h"
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include "gpu/ipc/service/command_buffer_stub.h" #include "gpu/ipc/service/command_buffer_stub.h"
#include "ipc/ipc_listener.h" #include "ipc/ipc_listener.h"
#include "ui/gl/android/surface_texture.h" #include "ui/gl/android/surface_texture.h"
......
...@@ -172,7 +172,7 @@ test("media_unittests") { ...@@ -172,7 +172,7 @@ test("media_unittests") {
deps += [ deps += [
# The test needs the java dependencies to add the java classes for their # The test needs the java dependencies to add the java classes for their
# native counterparts to the test apk. # native counterparts to the test apk.
"//gpu/ipc/common:android_texture_owner_unittests", "//gpu/command_buffer/service:android_texture_owner_unittests",
"//media/base/android:media_java", "//media/base/android:media_java",
"//media/base/android:unit_tests", "//media/base/android:unit_tests",
"//media/gpu:android_video_decode_accelerator_unittests", "//media/gpu:android_video_decode_accelerator_unittests",
......
...@@ -29,7 +29,8 @@ jumbo_source_set("base") { ...@@ -29,7 +29,8 @@ jumbo_source_set("base") {
} }
if (is_android) { if (is_android) {
visibility += [ "//gpu/ipc/common:android_texture_owner_unittests" ] visibility +=
[ "//gpu/command_buffer/service:android_texture_owner_unittests" ]
} }
sources = [ sources = [
......
...@@ -136,9 +136,7 @@ component("gpu") { ...@@ -136,9 +136,7 @@ component("gpu") {
] ]
libs += [ "android" ] libs += [ "android" ]
deps += [ deps += [
"//gpu/command_buffer/service:shared_image_video",
"//gpu/ipc/common:android_image_reader_utils", "//gpu/ipc/common:android_image_reader_utils",
"//gpu/ipc/common:android_texture_owner",
# TODO(crbug.com/789435): This can be removed once CdmManager is removed. # TODO(crbug.com/789435): This can be removed once CdmManager is removed.
"//gpu/ipc/common:ipc_common_sources", "//gpu/ipc/common:ipc_common_sources",
...@@ -427,7 +425,7 @@ if (is_win || is_android || use_v4l2_codec || use_vaapi) { ...@@ -427,7 +425,7 @@ if (is_win || is_android || use_v4l2_codec || use_vaapi) {
if (is_android) { if (is_android) {
deps += [ deps += [
":android_video_decode_accelerator_unittests", ":android_video_decode_accelerator_unittests",
"//gpu/ipc/common:android_texture_owner_unittests", "//gpu/command_buffer/service:android_texture_owner_unittests",
"//media/base/android:media_java", "//media/base/android:media_java",
"//media/test:run_all_unittests", "//media/test:run_all_unittests",
"//ui/android:ui_java", "//ui/android:ui_java",
...@@ -486,7 +484,7 @@ source_set("android_video_decode_accelerator_unittests") { ...@@ -486,7 +484,7 @@ source_set("android_video_decode_accelerator_unittests") {
":gpu", ":gpu",
"//base/test:test_support", "//base/test:test_support",
"//gpu:test_support", "//gpu:test_support",
"//gpu/ipc/common:android_texture_owner_test_support", "//gpu/command_buffer/service:android_texture_owner_test_support",
"//media", "//media",
"//media:test_support", "//media:test_support",
"//testing/gmock", "//testing/gmock",
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
#include "base/synchronization/waitable_event.h" #include "base/synchronization/waitable_event.h"
#include "base/threading/thread_checker.h" #include "base/threading/thread_checker.h"
#include "base/time/time.h" #include "base/time/time.h"
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include "media/gpu/media_gpu_export.h" #include "media/gpu/media_gpu_export.h"
namespace media { namespace media {
......
...@@ -10,9 +10,9 @@ ...@@ -10,9 +10,9 @@
#include "base/test/mock_callback.h" #include "base/test/mock_callback.h"
#include "base/test/task_environment.h" #include "base/test/task_environment.h"
#include "base/threading/sequenced_task_runner_handle.h" #include "base/threading/sequenced_task_runner_handle.h"
#include "gpu/command_buffer/service/mock_abstract_texture.h"
#include "gpu/command_buffer/service/mock_texture_owner.h"
#include "gpu/command_buffer/service/texture_manager.h" #include "gpu/command_buffer/service/texture_manager.h"
#include "gpu/ipc/common/android/mock_abstract_texture.h"
#include "gpu/ipc/common/android/mock_texture_owner.h"
#include "media/base/android/media_codec_bridge.h" #include "media/base/android/media_codec_bridge.h"
#include "media/base/android/mock_media_codec_bridge.h" #include "media/base/android/mock_media_codec_bridge.h"
#include "media/gpu/android/codec_image.h" #include "media/gpu/android/codec_image.h"
......
...@@ -6,7 +6,7 @@ ...@@ -6,7 +6,7 @@
#define MEDIA_GPU_ANDROID_CODEC_SURFACE_BUNDLE_H_ #define MEDIA_GPU_ANDROID_CODEC_SURFACE_BUNDLE_H_
#include "base/memory/ref_counted_delete_on_sequence.h" #include "base/memory/ref_counted_delete_on_sequence.h"
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include "media/base/android/android_overlay.h" #include "media/base/android/android_overlay.h"
#include "media/gpu/android/codec_buffer_wait_coordinator.h" #include "media/gpu/android/codec_buffer_wait_coordinator.h"
#include "media/gpu/media_gpu_export.h" #include "media/gpu/media_gpu_export.h"
......
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
#include "gpu/command_buffer/service/gles2_cmd_decoder.h" #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
#include "gpu/command_buffer/service/shared_image_representation.h" #include "gpu/command_buffer/service/shared_image_representation.h"
#include "gpu/command_buffer/service/texture_manager.h" #include "gpu/command_buffer/service/texture_manager.h"
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include "gpu/ipc/common/vulkan_ycbcr_info.h" #include "gpu/ipc/common/vulkan_ycbcr_info.h"
#include "gpu/ipc/service/command_buffer_stub.h" #include "gpu/ipc/service/command_buffer_stub.h"
#include "media/base/video_frame.h" #include "media/base/video_frame.h"
......
...@@ -12,8 +12,8 @@ ...@@ -12,8 +12,8 @@
#include "base/test/mock_callback.h" #include "base/test/mock_callback.h"
#include "base/test/task_environment.h" #include "base/test/task_environment.h"
#include "base/threading/thread_task_runner_handle.h" #include "base/threading/thread_task_runner_handle.h"
#include "gpu/command_buffer/service/mock_texture_owner.h"
#include "gpu/config/gpu_preferences.h" #include "gpu/config/gpu_preferences.h"
#include "gpu/ipc/common/android/mock_texture_owner.h"
#include "media/base/android/media_codec_util.h" #include "media/base/android/media_codec_util.h"
#include "media/base/android/mock_android_overlay.h" #include "media/base/android/mock_android_overlay.h"
#include "media/base/android/mock_media_crypto_context.h" #include "media/base/android/mock_media_crypto_context.h"
......
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
#ifndef MEDIA_GPU_ANDROID_MOCK_CODEC_BUFFER_WAIT_COORDINATOR_H_ #ifndef MEDIA_GPU_ANDROID_MOCK_CODEC_BUFFER_WAIT_COORDINATOR_H_
#define MEDIA_GPU_ANDROID_MOCK_CODEC_BUFFER_WAIT_COORDINATOR_H_ #define MEDIA_GPU_ANDROID_MOCK_CODEC_BUFFER_WAIT_COORDINATOR_H_
#include "gpu/ipc/common/android/mock_texture_owner.h" #include "gpu/command_buffer/service/mock_texture_owner.h"
#include "media/gpu/android/codec_buffer_wait_coordinator.h" #include "media/gpu/android/codec_buffer_wait_coordinator.h"
namespace media { namespace media {
......
...@@ -18,7 +18,7 @@ ...@@ -18,7 +18,7 @@
#include "base/trace_event/trace_event.h" #include "base/trace_event/trace_event.h"
#include "gpu/command_buffer/service/abstract_texture.h" #include "gpu/command_buffer/service/abstract_texture.h"
#include "gpu/command_buffer/service/shared_context_state.h" #include "gpu/command_buffer/service/shared_context_state.h"
#include "gpu/ipc/common/android/texture_owner.h" #include "gpu/command_buffer/service/texture_owner.h"
#include "media/base/bind_to_current_loop.h" #include "media/base/bind_to_current_loop.h"
#include "media/base/media_switches.h" #include "media/base/media_switches.h"
#include "media/base/video_frame.h" #include "media/base/video_frame.h"
......
...@@ -10,9 +10,9 @@ ...@@ -10,9 +10,9 @@
#include "base/test/mock_callback.h" #include "base/test/mock_callback.h"
#include "base/test/task_environment.h" #include "base/test/task_environment.h"
#include "base/threading/thread_task_runner_handle.h" #include "base/threading/thread_task_runner_handle.h"
#include "gpu/command_buffer/service/mock_texture_owner.h"
#include "gpu/command_buffer/service/shared_context_state.h" #include "gpu/command_buffer/service/shared_context_state.h"
#include "gpu/config/gpu_preferences.h" #include "gpu/config/gpu_preferences.h"
#include "gpu/ipc/common/android/mock_texture_owner.h"
#include "media/base/limits.h" #include "media/base/limits.h"
#include "media/gpu/android/codec_buffer_wait_coordinator.h" #include "media/gpu/android/codec_buffer_wait_coordinator.h"
#include "media/gpu/android/maybe_render_early_manager.h" #include "media/gpu/android/maybe_render_early_manager.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment