Commit 9c63e6f8 authored by edchin's avatar edchin Committed by Commit Bot

[ios][PhishGuard] Remove iOS-specific flag from /safe_browsing/content

Design doc: go/bling-phishguard

PASSWORD_REUSE_DETECTION_ENABLED is only defined for !is_ios.
This CL removes the use of this flag in files that are already
not compiled in iOS.

Bug: 1147962
Change-Id: I3ac6fca7db743442645ebe0bde4dda6a5a3fa554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543584Reviewed-by: default avatarBettina Dea <bdea@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828356}
parent 1e44de01
...@@ -593,9 +593,7 @@ void PasswordProtectionRequest::Finish( ...@@ -593,9 +593,7 @@ void PasswordProtectionRequest::Finish(
if (trigger_type_ == LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE) { if (trigger_type_ == LoginReputationClientRequest::UNFAMILIAR_LOGIN_PAGE) {
LogPasswordOnFocusRequestOutcome(outcome); LogPasswordOnFocusRequestOutcome(outcome);
} else { } else {
#if defined(PASSWORD_REUSE_DETECTION_ENABLED)
LogPasswordEntryRequestOutcome(outcome, password_account_type); LogPasswordEntryRequestOutcome(outcome, password_account_type);
#endif
#if defined(PASSWORD_REUSE_WARNING_ENABLED) #if defined(PASSWORD_REUSE_WARNING_ENABLED)
if (password_type_ == PasswordType::PRIMARY_ACCOUNT_PASSWORD) { if (password_type_ == PasswordType::PRIMARY_ACCOUNT_PASSWORD) {
......
...@@ -113,7 +113,6 @@ void PasswordProtectionService::MaybeStartPasswordFieldOnFocusRequest( ...@@ -113,7 +113,6 @@ void PasswordProtectionService::MaybeStartPasswordFieldOnFocusRequest(
} }
#endif #endif
#if defined(PASSWORD_REUSE_DETECTION_ENABLED)
void PasswordProtectionService::MaybeStartProtectedPasswordEntryRequest( void PasswordProtectionService::MaybeStartProtectedPasswordEntryRequest(
WebContents* web_contents, WebContents* web_contents,
const GURL& main_frame_url, const GURL& main_frame_url,
...@@ -168,7 +167,6 @@ void PasswordProtectionService::MaybeStartProtectedPasswordEntryRequest( ...@@ -168,7 +167,6 @@ void PasswordProtectionService::MaybeStartProtectedPasswordEntryRequest(
} }
#endif // defined(PASSWORD_REUSE_WARNING_ENABLED) #endif // defined(PASSWORD_REUSE_WARNING_ENABLED)
} }
#endif // defined(PASSWORD_REUSE_DETECTION_ENABLED)
#if defined(PASSWORD_REUSE_WARNING_ENABLED) #if defined(PASSWORD_REUSE_WARNING_ENABLED)
bool PasswordProtectionService::ShouldShowModalWarning( bool PasswordProtectionService::ShouldShowModalWarning(
......
...@@ -119,7 +119,6 @@ class PasswordProtectionService : public history::HistoryServiceObserver { ...@@ -119,7 +119,6 @@ class PasswordProtectionService : public history::HistoryServiceObserver {
const std::string& hosted_domain); const std::string& hosted_domain);
#endif #endif
#if defined(PASSWORD_REUSE_DETECTION_ENABLED)
virtual void MaybeStartProtectedPasswordEntryRequest( virtual void MaybeStartProtectedPasswordEntryRequest(
content::WebContents* web_contents, content::WebContents* web_contents,
const GURL& main_frame_url, const GURL& main_frame_url,
...@@ -128,7 +127,6 @@ class PasswordProtectionService : public history::HistoryServiceObserver { ...@@ -128,7 +127,6 @@ class PasswordProtectionService : public history::HistoryServiceObserver {
const std::vector<password_manager::MatchingReusedCredential>& const std::vector<password_manager::MatchingReusedCredential>&
matching_reused_credentials, matching_reused_credentials,
bool password_field_exists); bool password_field_exists);
#endif
#if defined(PASSWORD_REUSE_WARNING_ENABLED) #if defined(PASSWORD_REUSE_WARNING_ENABLED)
// Records a Chrome Sync event that sync password reuse was detected. // Records a Chrome Sync event that sync password reuse was detected.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment