Commit 9c80aaae authored by thestig@chromium.org's avatar thestig@chromium.org

Set url fetch test timeout back to old values. Increase UI test command...

Set url fetch test timeout back to old values. Increase UI test command timeout a bit to accommodate failng tests.

BUG=none
TEST=Vista perf goes green; xp test dbg 2 goes green.
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/3044007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52824 0039d316-1c4b-4281-b951-d872f2087c98
parent f333344a
...@@ -238,11 +238,11 @@ class PyUITest(pyautolib.PyUITestBase, unittest.TestCase): ...@@ -238,11 +238,11 @@ class PyUITest(pyautolib.PyUITestBase, unittest.TestCase):
Args: Args:
function: the function whose truth value is to be evaluated function: the function whose truth value is to be evaluated
timeout: the max timeout (in secs) for which to wait. The default timeout: the max timeout (in secs) for which to wait. The default
action is to wait for 60secs, and can be changed by action is to wait for kWaitForActionMaxMsec, as set in
changing kWaitForActionMaxMsec in ui_test.cc. ui_test.cc
Use None to wait indefinitely. Use None to wait indefinitely.
retry_sleep: the sleep interval (in secs) before retrying |function|. retry_sleep: the sleep interval (in secs) before retrying |function|.
Deaults to 0.25 secs. Defaults to 0.25 secs.
args: the args to pass to |function| args: the args to pass to |function|
Returns: Returns:
......
...@@ -55,7 +55,7 @@ using base::TimeTicks; ...@@ -55,7 +55,7 @@ using base::TimeTicks;
static const int kWaitForActionMsec = 2000; static const int kWaitForActionMsec = 2000;
static const int kWaitForActionMaxMsec = 15000; static const int kWaitForActionMaxMsec = 15000;
// Command execution timeout passed to AutomationProxy. // Command execution timeout passed to AutomationProxy.
static const int kCommandExecutionTimeout = 15000; static const int kCommandExecutionTimeout = 25000;
// Delay to let the browser shut down before trying more brutal methods. // Delay to let the browser shut down before trying more brutal methods.
static const int kWaitForTerminateMsec = 15000; static const int kWaitForTerminateMsec = 15000;
// Passed as value of kTestType. // Passed as value of kTestType.
......
...@@ -42,6 +42,10 @@ class UrlFetchTest : public UITest { ...@@ -42,6 +42,10 @@ class UrlFetchTest : public UITest {
browser_directory_ = dir; browser_directory_ = dir;
} }
UITest::SetUp(); UITest::SetUp();
// We've shortened the default timeouts, but dom_perf on Vista needs longer
// timeouts. Setting timeouts to the previous values before r52666.
set_action_timeout_ms(std::max(60000, action_timeout_ms()));
} }
void RunTest(const GURL& url, const char* wait_cookie_name, void RunTest(const GURL& url, const char* wait_cookie_name,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment