Commit 9c975776 authored by Mikhail Khokhlov's avatar Mikhail Khokhlov Committed by Commit Bot

[tools/perf] Fix trace processor invocation on Windows

Trace processor shell has limited command line parsing capabilities on
Windows; currently it supports only a subset of flags and only in
specific order. This CL brings the order of flags in accordance with
how the TP shell expects it.

Bug: 1028612
Change-Id: If8046d43e82bb55570a1ab2422286e336ce5bfc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980611Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#727280}
parent 5129bd56
......@@ -94,10 +94,10 @@ def RunMetric(trace_processor_path, trace_file, metric_name):
metric_files = _CreateMetricFiles(metric_name)
output = _RunTraceProcessor(
trace_processor_path,
trace_file,
'--run-metrics', metric_files.sql,
'--metrics-output=json',
'--extra-metrics', METRICS_PATH
'--metrics-output', 'json',
'--extra-metrics', METRICS_PATH,
trace_file,
)
measurements = json.loads(output)
......@@ -133,8 +133,8 @@ def ConvertProtoTraceToJson(trace_processor_path, proto_file, json_path):
query_file.close()
_RunTraceProcessor(
trace_processor_path,
proto_file,
'-q', query_file.name,
proto_file,
)
return json_path
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment