Commit 9ca977e3 authored by Theo Johnson-kanu's avatar Theo Johnson-kanu Committed by Chromium LUCI CQ

[CrOS cellular] Respond to cellular route params in internet page

Bug: 1163556
Change-Id: I196b9c9f73fecb169b53ac3d3ed5635a799b7138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625275
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: default avatarAzeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842903}
parent 5dec402f
......@@ -251,6 +251,7 @@ Polymer({
// e.g. chrome://settings/internet/networks?type=WiFi
const queryParams = settings.Router.getInstance().getQueryParameters();
const type = queryParams.get('type');
this.showCellularSetupDialog_ = !!queryParams.get('showCellularSetup');
if (type) {
this.subpageType_ = OncMojo.getNetworkTypeFromString(type);
}
......
......@@ -309,6 +309,40 @@ suite('InternetPage', function() {
removeDialog = internetPage.$$('#esimRemoveProfileDialog');
assertTrue(!!removeDialog);
});
test(
'Show cellular setup dialog if route params contain showCellularSetup',
async function() {
loadTimeData.overrideValues({
updatedCellularActivationUi: true,
});
eSimManagerRemote.addEuiccForTest(1);
const mojom = chromeos.networkConfig.mojom;
mojoApi_.setNetworkTypeEnabledState(
mojom.NetworkType.kCellular, true);
const cellularNetwork = OncMojo.getDefaultManagedProperties(
mojom.NetworkType.kCellular, 'cellular_guid', name);
cellularNetwork.connectable = false;
mojoApi_.setManagedPropertiesForTest(cellularNetwork);
await flushAsync();
let cellularSetupDialog = internetPage.$$('#cellularSetupDialog');
assertFalse(!!cellularSetupDialog);
const params = new URLSearchParams;
params.append('guid', 'cellular_guid');
params.append('type', 'Cellular');
params.append('name', 'cellular');
params.append('showCellularSetup', 'true');
settings.Router.getInstance().navigateTo(
settings.routes.INTERNET_NETWORKS, params);
await flushAsync();
cellularSetupDialog = internetPage.$$('#cellularSetupDialog');
assertTrue(!!cellularSetupDialog);
});
});
// TODO(stevenjb): Figure out a way to reliably test navigation. Currently
......
......@@ -971,7 +971,12 @@ var OSSettingsInternetPageTest = class extends OSSettingsBrowserTest {
/** @override */
get featureList() {
return {enabled: ['chromeos::features::kOsSettingsDeepLinking']};
return {
enabled: [
'chromeos::features::kOsSettingsDeepLinking',
'chromeos::features::kUpdatedCellularActivationUi',
]
};
}
/** @override */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment