Commit 9cadb2a3 authored by Sebastien Marchand's avatar Sebastien Marchand Committed by Commit Bot

Change a CHECK to DCHECK in LocalSiteCharacteristicsDataStore

This CHECK hasn't tripped in the recent Canary builds, it's safe to turn
it back into a DCHECK.

Bug: 966059
Change-Id: Ieeb23543146fb276d601790638b3d3fbd1880c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760279
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689136}
parent f28a73dd
...@@ -165,11 +165,8 @@ void LocalSiteCharacteristicsDataStore::OnURLsDeleted( ...@@ -165,11 +165,8 @@ void LocalSiteCharacteristicsDataStore::OnURLsDeleted(
} else { } else {
std::vector<url::Origin> origins_to_remove; std::vector<url::Origin> origins_to_remove;
// CHECK_EQ instead of DCHECK_EQ to determine if DCHECK_EQ(deletion_info.deleted_urls_origin_map().size(),
// https://crbug.com/966059 still happens in production. CountOriginsInURLRows(deletion_info.deleted_rows()));
// TODO(sebmarchand): Remove once https://crbug.com/966059 is fixed.
CHECK_EQ(deletion_info.deleted_urls_origin_map().size(),
CountOriginsInURLRows(deletion_info.deleted_rows()));
for (const auto& it : deletion_info.deleted_urls_origin_map()) { for (const auto& it : deletion_info.deleted_urls_origin_map()) {
const url::Origin origin = url::Origin::Create(it.first); const url::Origin origin = url::Origin::Create(it.first);
const int remaining_visits_in_history = it.second.first; const int remaining_visits_in_history = it.second.first;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment