Commit 9cb1cb5b authored by pneubeck@chromium.org's avatar pneubeck@chromium.org

Extend SplitStringIntoKeyValuePairs unit tests.

Extends the unit tests about corner cases to ensure that changes to the implementation don't break these.
Test cases of the internal helper function SplitStringIntoKeyValues are merged into tests of the public function SplitStringIntoKeyValuesPairs. This removes redundancy in the tests and improves coverage of SplitStringIntoKeyValuesPairs.

The helper function is removed from the public header.

BUG=NONE

Review URL: https://codereview.chromium.org/184233009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255758 0039d316-1c4b-4281-b951-d872f2087c98
parent 18900c1b
......@@ -31,11 +31,6 @@ BASE_EXPORT void SplitString(const std::string& str,
char c,
std::vector<std::string>* r);
BASE_EXPORT bool SplitStringIntoKeyValues(const std::string& line,
char key_value_delimiter,
std::string* key,
std::vector<std::string>* values);
typedef std::vector<std::pair<std::string, std::string> > StringPairs;;
BASE_EXPORT bool SplitStringIntoKeyValuePairs(
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment