Commit 9cb89c11 authored by Jinsuk Kim's avatar Jinsuk Kim Committed by Commit Bot

Android: Fix the bug not showing text suggestion

Lazy init (https://crrev.com/578223) doesn't work for
TextSuggestionHost whose UI gets triggered by native from Blink.
It expects the related components (java TextSuggestionHost and
blink::mojom::TextSuggestionHost) to be ready before it makes
the first call. This CL initializes the objects in eager fashion.

Bug: 884214
Change-Id: I1ef96d7d617a1fb745f2652a7e1f94e5d9406a24
Reviewed-on: https://chromium-review.googlesource.com/1253312Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595608}
parent 237405af
...@@ -34,6 +34,7 @@ import org.chromium.content.browser.WindowEventObserverManager; ...@@ -34,6 +34,7 @@ import org.chromium.content.browser.WindowEventObserverManager;
import org.chromium.content.browser.accessibility.WebContentsAccessibilityImpl; import org.chromium.content.browser.accessibility.WebContentsAccessibilityImpl;
import org.chromium.content.browser.framehost.RenderFrameHostDelegate; import org.chromium.content.browser.framehost.RenderFrameHostDelegate;
import org.chromium.content.browser.framehost.RenderFrameHostImpl; import org.chromium.content.browser.framehost.RenderFrameHostImpl;
import org.chromium.content.browser.input.TextSuggestionHost;
import org.chromium.content.browser.selection.SelectionPopupControllerImpl; import org.chromium.content.browser.selection.SelectionPopupControllerImpl;
import org.chromium.content_public.browser.AccessibilitySnapshotCallback; import org.chromium.content_public.browser.AccessibilitySnapshotCallback;
import org.chromium.content_public.browser.AccessibilitySnapshotNode; import org.chromium.content_public.browser.AccessibilitySnapshotNode;
...@@ -229,6 +230,7 @@ public class WebContentsImpl implements WebContents, RenderFrameHostDelegate, Wi ...@@ -229,6 +230,7 @@ public class WebContentsImpl implements WebContents, RenderFrameHostDelegate, Wi
ViewEventSinkImpl.from(this).setAccessDelegate(accessDelegate); ViewEventSinkImpl.from(this).setAccessDelegate(accessDelegate);
getRenderCoordinates().setDeviceScaleFactor(windowAndroid.getDisplay().getDipScale()); getRenderCoordinates().setDeviceScaleFactor(windowAndroid.getDisplay().getDipScale());
TextSuggestionHost.fromWebContents(this);
} }
@Nullable @Nullable
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment