Commit 9cc13217 authored by proberge's avatar proberge Committed by Commit Bot

Chrome settings: adjust CSS to fix relayout of settings_toggle_button

In https://chromium-review.googlesource.com/c/chromium/src/+/1133300 I
changed how the padding of settings_toggle_button is calculated. This
caused some issues in cases where clicking the row creates a button
whose height is greater than the text's height, causing the entire row
to expand vertically.

This change applies the padding modifications to the text label instead
of the entire outerRow, preventing the padding from applying based on
the button's height instead of the text height.

Bug: 862916
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I489f8e38d022452e448ab452def29ca02aa0a1cb
Reviewed-on: https://chromium-review.googlesource.com/1135594
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574962}
parent 243c4f41
...@@ -31,10 +31,8 @@ ...@@ -31,10 +31,8 @@
#outerRow { #outerRow {
align-items: center; align-items: center;
box-sizing: border-box;
display: flex; display: flex;
min-height: var(--settings-row-two-line-min-height); min-height: var(--settings-row-two-line-min-height);
padding: 12px 0;
width: 100%; width: 100%;
} }
...@@ -42,6 +40,10 @@ ...@@ -42,6 +40,10 @@
min-height: var(--settings-row-min-height); min-height: var(--settings-row-min-height);
} }
#labelWrapper {
padding: 12px 0;
}
#labelWrapper, #labelWrapper,
::slotted([slot='more-actions']) { ::slotted([slot='more-actions']) {
-webkit-margin-end: var(--settings-control-label-spacing); -webkit-margin-end: var(--settings-control-label-spacing);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment