Commit 9cf57f49 authored by Sunny Sachanandani's avatar Sunny Sachanandani Committed by Commit Bot

gpu: Add crash key for GLContext::SetCurrent stack trace.

We know that current context is set to null when the crash happens.
Getting the stack trace for the last call to SetCurrent will be helpful.

BUG=724999

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie99e7c6cd0c9faa162cd0fc789c23d321256ded7
Reviewed-on: https://chromium-review.googlesource.com/780391Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Reviewed-by: default avatarLuke Halliwell <halliwell@chromium.org>
Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Reviewed-by: default avatarScott Graham <scottmg@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519943}
parent f2c84f00
......@@ -95,6 +95,9 @@ size_t RegisterWebViewCrashKeys() {
// Temporary for https://crbug.com/685996.
{"user-cloud-policy-manager-connect-trace", kMediumSize},
// TODO(sunnyps): Remove after fixing crbug.com/724999.
{"gl-context-set-current-stack-trace", kMediumSize},
// Accessibility keys. Temporary for http://crbug.com/765490.
{"ax_tree_error", kSmallSize},
{"ax_tree_update", kMediumSize},
......
......@@ -159,6 +159,9 @@ size_t RegisterCrashKeysHelper() {
// Temporary for https://crbug.com/685996.
{"user-cloud-policy-manager-connect-trace", kMediumSize},
// TODO(sunnyps): Remove after fixing crbug.com/724999.
{"gl-context-set-current-stack-trace", kMediumSize},
// TODO(asvitkine): Remove after fixing https://crbug.com/736675
{"bad_histogram", kMediumSize},
......
......@@ -197,6 +197,9 @@ size_t RegisterChromeCrashKeys() {
// Temporary for https://crbug.com/685996.
{kUserCloudPolicyManagerConnectTrace, kMediumSize},
// TODO(sunnyps): Remove after fixing crbug.com/724999.
{"gl-context-set-current-stack-trace", kMediumSize},
// TODO(asvitkine): Remove after fixing https://crbug.com/736675
{"bad_histogram", kMediumSize},
......
......@@ -78,6 +78,9 @@ size_t RegisterCastCrashKeys() {
// Temporary for https://crbug.com/685996.
{"user-cloud-policy-manager-connect-trace", ::crash_keys::kMediumSize},
// TODO(sunnyps): Remove after fixing crbug.com/724999.
{"gl-context-set-current-stack-trace", ::crash_keys::kMediumSize},
// Accessibility keys. Temporary for http://crbug.com/765490.
{"ax_tree_error", ::crash_keys::kSmallSize},
{"ax_tree_update", ::crash_keys::kMediumSize},
......
......@@ -9,6 +9,8 @@
#include "base/bind.h"
#include "base/cancelable_callback.h"
#include "base/command_line.h"
#include "base/debug/crash_logging.h"
#include "base/debug/stack_trace.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
#include "base/memory/ptr_util.h"
......@@ -251,6 +253,9 @@ void GLContext::SetCurrent(GLSurface* surface) {
// to create and make current a context.
if (!surface && GetGLImplementation() != kGLImplementationMockGL &&
GetGLImplementation() != kGLImplementationStubGL) {
// TODO(sunnyps): Remove after fixing crbug.com/724999.
base::debug::SetCrashKeyToStackTrace("gl-context-set-current-stack-trace",
base::debug::StackTrace());
SetCurrentGL(nullptr);
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment