[wrapper-tracing] CHECK against isWrapperTracingForbidden instead of isGCForbidden

We only require proper tracing functionality but don't trigger any collection on
the Oilpan heap. Introduce a new getter ThreadState::isWrapperTracingForbidden()
for that purpose.

Drive-by: CHECK on calling v8::Function that we are indeed allowed to trace
wrappers.

BUG=chromium:468240

Review-Url: https://codereview.chromium.org/2532133003
Cr-Commit-Position: refs/heads/master@{#434994}

third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp

@@ -30,7 +30,7 @@ void ScriptWrappableVisitor::TracePrologue() {
   // This CHECK ensures that wrapper tracing is not started from scopes
   // that forbid GC execution, e.g., constructors.
   CHECK(ThreadState::current());
-  CHECK(!ThreadState::current()->isGCForbidden());
+  CHECK(!ThreadState::current()->isWrapperTracingForbidden());
   performCleanup();
 
   CHECK(!m_tracingInProgress);
@@ -43,13 +43,13 @@ void ScriptWrappableVisitor::TracePrologue() {
 
 void ScriptWrappableVisitor::EnterFinalPause() {
   CHECK(ThreadState::current());
-  CHECK(!ThreadState::current()->isGCForbidden());
+  CHECK(!ThreadState::current()->isWrapperTracingForbidden());
   ActiveScriptWrappable::traceActiveScriptWrappables(m_isolate, this);
 }
 
 void ScriptWrappableVisitor::TraceEpilogue() {
   CHECK(ThreadState::current());
-  CHECK(!ThreadState::current()->isGCForbidden());
+  CHECK(!ThreadState::current()->isWrapperTracingForbidden());
   DCHECK(m_markingDeque.isEmpty());
 #if DCHECK_IS_ON()
   ScriptWrappableVisitorVerifier verifier;
@@ -185,7 +185,7 @@ bool ScriptWrappableVisitor::AdvanceTracing(
   // perform a GC. This makes sure that TraceTraits and friends find
   // themselves in a well-defined environment, e.g., properly set up vtables.
   CHECK(ThreadState::current());
-  CHECK(!ThreadState::current()->isGCForbidden());
+  CHECK(!ThreadState::current()->isWrapperTracingForbidden());
   CHECK(m_tracingInProgress);
   WTF::AutoReset<bool>(&m_advancingTracing, true);
   while (actions.force_completion ==

third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

@@ -629,6 +629,7 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callFunction(
     TRACE_EVENT_BEGIN1("devtools.timeline", "FunctionCall", "data",
                        InspectorFunctionCallEvent::data(context, function));
 
+  CHECK(!ThreadState::current()->isWrapperTracingForbidden());
   v8::MicrotasksScope microtasksScope(isolate,
                                       v8::MicrotasksScope::kRunMicrotasks);
   PerformanceMonitor::willCallFunction(context);
@@ -650,6 +651,7 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::callInternalFunction(
     v8::Local<v8::Value> args[],
     v8::Isolate* isolate) {
   TRACE_EVENT0("v8", "v8.callFunction");
+  CHECK(!ThreadState::current()->isWrapperTracingForbidden());
   v8::MicrotasksScope microtasksScope(isolate,
                                       v8::MicrotasksScope::kDoNotRunMicrotasks);
   v8::MaybeLocal<v8::Value> result =

third_party/WebKit/Source/platform/heap/ThreadState.h

@@ -292,6 +292,7 @@ class PLATFORM_EXPORT ThreadState {
   }
   void enterNoAllocationScope() { m_noAllocationCount++; }
   void leaveNoAllocationScope() { m_noAllocationCount--; }
+  bool isWrapperTracingForbidden() { return isMixinInConstruction(); }
   bool isGCForbidden() const {
     return m_gcForbiddenCount || isMixinInConstruction();
   }