Adjust some network interface APIs to avoid truncation errors.

Some blink public interfaces used size_t then truncated on the calls
internally to int. Use size_t throughout call graph.

BUG=879657

Change-Id: I3c124524c2e969b65e662a30d0c8898d9d4e01a5
Reviewed-on: https://chromium-review.googlesource.com/c/1354061Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611767}

content/renderer/appcache/web_application_cache_host_impl.cc

@@ -262,7 +262,7 @@ void WebApplicationCacheHostImpl::DidReceiveResponseForMainResource(
 
 void WebApplicationCacheHostImpl::DidReceiveDataForMainResource(
     const char* data,
-    unsigned len) {
+    size_t len) {
   if (is_new_master_entry_ == OLD_ENTRY)
     return;
   // TODO(michaeln): write me

content/renderer/appcache/web_application_cache_host_impl.h

@@ -48,7 +48,7 @@ class WebApplicationCacheHostImpl : public blink::WebApplicationCacheHost {
   void SelectCacheWithoutManifest() override;
   bool SelectCacheWithManifest(const blink::WebURL& manifestURL) override;
   void DidReceiveResponseForMainResource(const blink::WebURLResponse&) override;
-  void DidReceiveDataForMainResource(const char* data, unsigned len) override;
+  void DidReceiveDataForMainResource(const char* data, size_t len) override;
   void DidFinishLoadingMainResource(bool success) override;
   blink::WebApplicationCacheHost::Status GetStatus() override;
   bool StartUpdate() override;

content/renderer/shared_worker/embedded_shared_worker_stub.cc

@@ -71,7 +71,7 @@ class SharedWorkerWebApplicationCacheHostImpl
       const WebApplicationCacheHost* spawning_host) override {}
   void DidReceiveResponseForMainResource(
       const blink::WebURLResponse&) override {}
-  void DidReceiveDataForMainResource(const char* data, unsigned len) override {}
+  void DidReceiveDataForMainResource(const char* data, size_t len) override {}
   void DidFinishLoadingMainResource(bool success) override {}
 
   // Cache selection is also different for workers. We know at construction

third_party/blink/public/platform/web_application_cache_host.h

@@ -100,7 +100,7 @@ class WebApplicationCacheHost {
 
   // Called as the main resource is retrieved.
   virtual void DidReceiveResponseForMainResource(const WebURLResponse&) {}
-  virtual void DidReceiveDataForMainResource(const char* data, unsigned len) {}
+  virtual void DidReceiveDataForMainResource(const char* data, size_t len) {}
   virtual void DidFinishLoadingMainResource(bool success) {}
 
   // Called on behalf of the scriptable interface.

third_party/blink/renderer/core/inspector/inspector_network_agent.cc

@@ -955,7 +955,7 @@ static bool IsErrorStatusCode(int status_code) {
 void InspectorNetworkAgent::DidReceiveData(unsigned long identifier,
                                            DocumentLoader* loader,
                                            const char* data,
-                                           int data_length) {
+                                           size_t data_length) {
   String request_id = IdentifiersFactory::RequestId(loader, identifier);
 
   if (data) {
@@ -984,7 +984,7 @@ void InspectorNetworkAgent::DidReceiveBlob(unsigned long identifier,
 void InspectorNetworkAgent::DidReceiveEncodedDataLength(
     DocumentLoader* loader,
     unsigned long identifier,
-    int encoded_data_length) {
+    size_t encoded_data_length) {
   String request_id = IdentifiersFactory::RequestId(loader, identifier);
   resources_data_->AddPendingEncodedDataLength(request_id, encoded_data_length);
 }

third_party/blink/renderer/core/inspector/inspector_network_agent.h

@@ -109,13 +109,13 @@ class CORE_EXPORT InspectorNetworkAgent final
   void DidReceiveData(unsigned long identifier,
                       DocumentLoader*,
                       const char* data,
-                      int data_length);
+                      size_t data_length);
   void DidReceiveBlob(unsigned long identifier,
                       DocumentLoader*,
                       scoped_refptr<BlobDataHandle>);
   void DidReceiveEncodedDataLength(DocumentLoader*,
                                    unsigned long identifier,
-                                   int encoded_data_length);
+                                   size_t encoded_data_length);
   void DidFinishLoading(unsigned long identifier,
                         DocumentLoader*,
                         TimeTicks monotonic_finish_time,

third_party/blink/renderer/core/inspector/network_resources_data.cc

@@ -368,20 +368,21 @@ NetworkResourcesData::Resources() {
   return result;
 }
 
-int NetworkResourcesData::GetAndClearPendingEncodedDataLength(
+int64_t NetworkResourcesData::GetAndClearPendingEncodedDataLength(
     const String& request_id) {
   ResourceData* resource_data = ResourceDataForRequestId(request_id);
   if (!resource_data)
     return 0;
 
-  int pending_encoded_data_length = resource_data->PendingEncodedDataLength();
+  int64_t pending_encoded_data_length =
+      resource_data->PendingEncodedDataLength();
   resource_data->ClearPendingEncodedDataLength();
   return pending_encoded_data_length;
 }
 
 void NetworkResourcesData::AddPendingEncodedDataLength(
     const String& request_id,
-    int encoded_data_length) {
+    size_t encoded_data_length) {
   ResourceData* resource_data = ResourceDataForRequestId(request_id);
   if (!resource_data)
     return;

third_party/blink/renderer/core/inspector/network_resources_data.h

@@ -152,11 +152,11 @@ class NetworkResourcesData final
     void SetCertificate(const Vector<AtomicString>& certificate) {
       certificate_ = certificate;
     }
-    int PendingEncodedDataLength() const {
+    int64_t PendingEncodedDataLength() const {
       return pending_encoded_data_length_;
     }
     void ClearPendingEncodedDataLength() { pending_encoded_data_length_ = 0; }
-    void AddPendingEncodedDataLength(int encoded_data_length) {
+    void AddPendingEncodedDataLength(size_t encoded_data_length) {
       pending_encoded_data_length_ += encoded_data_length;
     }
     void SetPostData(scoped_refptr<EncodedFormData> post_data) {
@@ -189,7 +189,7 @@ class NetworkResourcesData final
     String mime_type_;
     String text_encoding_name_;
     int64_t raw_header_size_;
-    int pending_encoded_data_length_;
+    int64_t pending_encoded_data_length_;
 
     scoped_refptr<SharedBuffer> buffer_;
     WeakMember<Resource> cached_resource_;
@@ -239,9 +239,9 @@ class NetworkResourcesData final
                       const Vector<AtomicString>& certificate);
   HeapVector<Member<ResourceData>> Resources();
 
-  int GetAndClearPendingEncodedDataLength(const String& request_id);
+  int64_t GetAndClearPendingEncodedDataLength(const String& request_id);
   void AddPendingEncodedDataLength(const String& request_id,
-                                   int encoded_data_length);
+                                   size_t encoded_data_length);
   void Trace(blink::Visitor*);
 
  private:

third_party/blink/renderer/core/loader/progress_tracker.cc

@@ -165,7 +165,8 @@ void ProgressTracker::IncrementProgress(unsigned long identifier,
   item->estimated_length = estimated_length;
 }
 
-void ProgressTracker::IncrementProgress(unsigned long identifier, int length) {
+void ProgressTracker::IncrementProgress(unsigned long identifier,
+                                        size_t length) {
   ProgressItem* item = progress_items_.at(identifier);
   if (!item)
     return;

third_party/blink/renderer/core/loader/progress_tracker.h

@@ -66,7 +66,7 @@ class CORE_EXPORT ProgressTracker final
 
   void WillStartLoading(unsigned long identifier, ResourceLoadPriority);
   void IncrementProgress(unsigned long identifier, const ResourceResponse&);
-  void IncrementProgress(unsigned long identifier, int);
+  void IncrementProgress(unsigned long identifier, size_t);
   void CompleteProgress(unsigned long identifier);
 
  private:

third_party/blink/renderer/core/probe/core_probes.pidl

@@ -94,9 +94,9 @@ interface CoreProbes {
   void willSendRequest([Keep] ExecutionContext*, unsigned long identifier, DocumentLoader*, ResourceRequest&, const ResourceResponse& redirectResponse, const FetchInitiatorInfo&, ResourceType);
   void markResourceAsCached(LocalFrame*, DocumentLoader*, unsigned long identifier);
   void didReceiveResourceResponse(ExecutionContext*, unsigned long identifier, DocumentLoader*, const ResourceResponse&, Resource*);
-  void didReceiveData(ExecutionContext*, unsigned long identifier, DocumentLoader*, const char* data, int dataLength);
+  void didReceiveData(ExecutionContext*, unsigned long identifier, DocumentLoader*, const char* data, size_t dataLength);
   void didReceiveBlob(ExecutionContext*, unsigned long identifier, DocumentLoader*, BlobDataHandle*);
-  void didReceiveEncodedDataLength(ExecutionContext*, DocumentLoader* loader, unsigned long identifier, int encodedDataLength);
+  void didReceiveEncodedDataLength(ExecutionContext*, DocumentLoader* loader, unsigned long identifier, size_t encodedDataLength);
   void didFinishLoading(ExecutionContext*, unsigned long identifier, DocumentLoader*, TimeTicks finishTime, int64_t encoded_data_length, int64_t decodedBodyLength, bool should_report_corb_blocking);
   void didReceiveCorsRedirectResponse(ExecutionContext*, unsigned long identifier, DocumentLoader*, const ResourceResponse&, Resource*);
   void didFailLoading(ExecutionContext*, unsigned long identifier, DocumentLoader*, const ResourceError&);