Commit 9d37d514 authored by Jay Harris's avatar Jay Harris Committed by Commit Bot

Stop drawing border between window frame and toolbar in PWAs.

The custom tab bar should appear as an extension of the
title bar. Before this CL, this was not not the case on
Linux or Windows without DWM (disable-dwm-composition),
as we draw small borders between the window frame and the
toolbar. This CL removes them when displaying the custom
tab bar.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=372746&signed_aid=ybrF8gUqHfRhz-mI-R7-SQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=372747&signed_aid=-_9BQ_5YxzT6Gg67Aj49ag==&inline=1

Bug: 853593
Change-Id: Ice90aef02c074d344066f8b5dd8e50fe77310a8e
Reviewed-on: https://chromium-review.googlesource.com/c/1385685
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618404}
parent a4bd5ce4
...@@ -552,7 +552,10 @@ void OpaqueBrowserFrameView::OnPaint(gfx::Canvas* canvas) { ...@@ -552,7 +552,10 @@ void OpaqueBrowserFrameView::OnPaint(gfx::Canvas* canvas) {
* So we'd need to sample the background color at the right location and * So we'd need to sample the background color at the right location and
* synthesize a good shadow color. */ * synthesize a good shadow color. */
PaintClientEdge(canvas); // Custom tab bar mode draws the toolbar as a unified part of the titlebar, so
// it shouldn't have a client edge.
if (!browser_view()->toolbar()->custom_tab_bar())
PaintClientEdge(canvas);
} }
// BrowserNonClientFrameView: // BrowserNonClientFrameView:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment