Commit 9d4ff755 authored by sullivan's avatar sullivan Committed by Commit bot

Properly escape goma dir on windows. Fixes errors in goma path.

BUG=394990

Review URL: https://codereview.chromium.org/583793002

Cr-Commit-Position: refs/heads/master@{#295704}
parent fb35e64a
...@@ -40,7 +40,8 @@ class Builder(object): ...@@ -40,7 +40,8 @@ class Builder(object):
'Path to visual studio could not be determined.') 'Path to visual studio could not be determined.')
else: else:
SetBuildSystemDefault(opts.build_preference, opts.use_goma, SetBuildSystemDefault(opts.build_preference, opts.use_goma,
opts.goma_dir) # Need to re-escape goma dir, see crbug.com/394990
opts.goma_dir.encode('string_escape'))
else: else:
if not opts.build_preference: if not opts.build_preference:
if 'ninja' in os.getenv('GYP_GENERATORS', default=''): if 'ninja' in os.getenv('GYP_GENERATORS', default=''):
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment