Commit 9d96669d authored by Xing Liu's avatar Xing Liu Committed by Commit Bot

Background download: Delete hash histogram.

This CL deletes histogram Download.Service.Finish.ReportedHash. Over
99% of background downloads have hash, it's not very actionable.

Bug: 995485
Change-Id: I1176f5d37d608e99eba0acf8fdfa50ea938d5569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803880Reviewed-by: default avatarMin Qin <qinmin@chromium.org>
Reviewed-by: default avatarShakti Sahu <shaktisahu@chromium.org>
Reviewed-by: default avatarNik Bhagat <nikunjb@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697769}
parent ad8820a6
...@@ -1153,7 +1153,6 @@ void ControllerImpl::HandleCompleteDownload(CompletionType type, ...@@ -1153,7 +1153,6 @@ void ControllerImpl::HandleCompleteDownload(CompletionType type,
DCHECK(driver_entry.has_value()); DCHECK(driver_entry.has_value());
stats::LogFilePathRenamed(driver_entry->current_file_path != stats::LogFilePathRenamed(driver_entry->current_file_path !=
entry->target_file_path); entry->target_file_path);
stats::LogHashPresence(!driver_entry->hash256.empty());
entry->target_file_path = driver_entry->current_file_path; entry->target_file_path = driver_entry->current_file_path;
entry->completion_time = driver_entry->completion_time; entry->completion_time = driver_entry->completion_time;
entry->bytes_downloaded = driver_entry->bytes_downloaded; entry->bytes_downloaded = driver_entry->bytes_downloaded;
......
...@@ -330,10 +330,6 @@ void LogHasUploadData(DownloadClient client, bool has_upload_data) { ...@@ -330,10 +330,6 @@ void LogHasUploadData(DownloadClient client, bool has_upload_data) {
base::UmaHistogramBoolean(name, has_upload_data); base::UmaHistogramBoolean(name, has_upload_data);
} }
void LogHashPresence(bool hash_exists) {
UMA_HISTOGRAM_BOOLEAN("Download.Service.Finish.ReportedHash", hash_exists);
}
void LogDownloadClientInflatedFullBrowser(DownloadClient client) { void LogDownloadClientInflatedFullBrowser(DownloadClient client) {
std::string client_name(ClientToHistogramSuffix(client)); std::string client_name(ClientToHistogramSuffix(client));
base::UmaHistogramBoolean( base::UmaHistogramBoolean(
......
...@@ -220,9 +220,6 @@ void LogEntryRetryCount(uint32_t retry_count); ...@@ -220,9 +220,6 @@ void LogEntryRetryCount(uint32_t retry_count);
// Records whether the entry was an upload. // Records whether the entry was an upload.
void LogHasUploadData(DownloadClient client, bool has_upload_data); void LogHasUploadData(DownloadClient client, bool has_upload_data);
// Records whether or not a completed entry has a hash value.
void LogHashPresence(bool hash_exists);
// Records count of reduced mode to full browser transitions requested by each // Records count of reduced mode to full browser transitions requested by each
// client. // client.
void LogDownloadClientInflatedFullBrowser(DownloadClient client); void LogDownloadClientInflatedFullBrowser(DownloadClient client);
......
...@@ -34302,6 +34302,9 @@ uploading your change for review. ...@@ -34302,6 +34302,9 @@ uploading your change for review.
<histogram name="Download.Service.Finish.ReportedHash" <histogram name="Download.Service.Finish.ReportedHash"
enum="BooleanIncludesHash" expires_after="2019-10-01"> enum="BooleanIncludesHash" expires_after="2019-10-01">
<obsolete>
Deprecated in 09/2019.
</obsolete>
<owner>dtrainor@chromium.org</owner> <owner>dtrainor@chromium.org</owner>
<owner>xingliu@chromium.org</owner> <owner>xingliu@chromium.org</owner>
<summary> <summary>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment