Remove sync OnTransaction{Start,End} notification

BUG=105814
TEST=


Review URL: http://codereview.chromium.org/8741001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112556 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/resources/sync_internals/chrome_sync.js

@@ -91,9 +91,7 @@ chrome.sync.events = {
   ],
 
   'transaction': [
-    'onTransactionStart',
     'onTransactionWrite',
-    'onTransactionEnd'
   ]
 };
 

chrome/browser/sync/js/js_mutation_event_observer.cc

@@ -35,19 +35,6 @@ void JsMutationEventObserver::SetJsEventHandler(
   event_handler_ = event_handler;
 }
 
-void JsMutationEventObserver::OnTransactionStart(
-    const tracked_objects::Location& location,
-    const syncable::WriterTag& writer) {
-  DCHECK(non_thread_safe_.CalledOnValidThread());
-  if (!event_handler_.IsInitialized()) {
-    return;
-  }
-  DictionaryValue details;
-  details.SetString("location", location.ToString());
-  details.SetString("writer", syncable::WriterTagToString(writer));
-  HandleJsEvent(FROM_HERE, "onTransactionStart", JsEventDetails(&details));
-}
-
 namespace {
 
 // Max number of changes we attempt to convert to values (to avoid
@@ -111,19 +98,6 @@ void JsMutationEventObserver::OnTransactionWrite(
   HandleJsEvent(FROM_HERE, "onTransactionWrite", JsEventDetails(&details));
 }
 
-void JsMutationEventObserver::OnTransactionEnd(
-    const tracked_objects::Location& location,
-    const syncable::WriterTag& writer) {
-  DCHECK(non_thread_safe_.CalledOnValidThread());
-  if (!event_handler_.IsInitialized()) {
-    return;
-  }
-  DictionaryValue details;
-  details.SetString("location", location.ToString());
-  details.SetString("writer", syncable::WriterTagToString(writer));
-  HandleJsEvent(FROM_HERE, "onTransactionEnd", JsEventDetails(&details));
-}
-
 void JsMutationEventObserver::HandleJsEvent(
     const tracked_objects::Location& from_here,
     const std::string& name, const JsEventDetails& details) {

chrome/browser/sync/js/js_mutation_event_observer.h

@@ -49,15 +49,9 @@ class JsMutationEventObserver
   virtual void OnChangesComplete(syncable::ModelType model_type) OVERRIDE;
 
   // syncable::TransactionObserver implementation.
-  virtual void OnTransactionStart(
-      const tracked_objects::Location& location,
-      const syncable::WriterTag& writer) OVERRIDE;
   virtual void OnTransactionWrite(
       const syncable::ImmutableWriteTransactionInfo& write_transaction_info,
       const syncable::ModelTypeBitSet& models_with_changes) OVERRIDE;
-  virtual void OnTransactionEnd(
-      const tracked_objects::Location& location,
-      const syncable::WriterTag& writer) OVERRIDE;
 
  private:
   base::NonThreadSafe non_thread_safe_;

chrome/browser/sync/syncable/syncable.cc

@@ -1195,15 +1195,9 @@ BaseTransaction::BaseTransaction(const tracked_objects::Location& from_here,
   TRACE_EVENT_BEGIN2("sync", name_,
                      "src_file", from_here_.file_name(),
                      "src_func", from_here_.function_name());
-  dirkernel_->transaction_observer.Call(FROM_HERE,
-      &TransactionObserver::OnTransactionStart, from_here_, writer_);
 }
 
 BaseTransaction::~BaseTransaction() {
-  if (writer_ != INVALID) {
-    dirkernel_->transaction_observer.Call(FROM_HERE,
-        &TransactionObserver::OnTransactionEnd, from_here_, writer_);
-  }
   TRACE_EVENT_END0("sync", name_);
 }
 

chrome/browser/sync/syncable/transaction_observer.h

@@ -9,23 +9,13 @@
 #include "chrome/browser/sync/syncable/model_type.h"
 #include "chrome/browser/sync/syncable/syncable.h"
 
-namespace tracked_objects {
-class Location;
-}  // namespace tracked_objects
-
 namespace syncable {
 
 class TransactionObserver {
  public:
-  virtual void OnTransactionStart(
-      const tracked_objects::Location& location,
-      const WriterTag& writer) = 0;
   virtual void OnTransactionWrite(
       const ImmutableWriteTransactionInfo& write_transaction_info,
       const ModelTypeBitSet& models_with_changes) = 0;
-  virtual void OnTransactionEnd(
-      const tracked_objects::Location& location,
-      const WriterTag& writer) = 0;
  protected:
   virtual ~TransactionObserver() {}
 };