Commit 9db07132 authored by Dan Beam's avatar Dan Beam Committed by Commit Bot

devtools: make Network more useful for internal (e.g. chrome://) URLs

The Size column of Network panel shows "0 B" for every request when no
bytes are actually transferred over the network.  Enabling "large rows"
is great as it shows the resource size as well, but sorting doesn't take
the resource size into account as a secondary factor.  This CL fixes
that.

I also added a summary view of the resource sizes (very similar to the
network bytes transferred summary) to the bottom start end of network
tab.

Screenshot: https://imgur.com/XQRYtWj

R=alph@chromium.org
BUG=907289

Change-Id: I35d69cb617113b0094f6cc2a368b6180c90c2772
Reviewed-on: https://chromium-review.googlesource.com/c/1345232Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Reviewed-by: default avatarAlexei Filippov <alph@chromium.org>
Reviewed-by: default avatarPaul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612937}
parent 453107f2
......@@ -365,7 +365,8 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
return 1;
if (aRequest.cached() && !bRequest.cached())
return -1;
return (aRequest.transferSize - bRequest.transferSize) || aRequest.indentityCompare(bRequest);
return (aRequest.transferSize - bRequest.transferSize) || (aRequest.resourceSize - bRequest.resourceSize) ||
aRequest.indentityCompare(bRequest);
}
/**
......
......@@ -696,8 +696,10 @@ Network.NetworkLogView = class extends UI.VBox {
this._hideRecordingHint();
let transferSize = 0;
let resourceSize = 0;
let selectedNodeNumber = 0;
let selectedTransferSize = 0;
let selectedResourceSize = 0;
let baseTime = -1;
let maxTime = -1;
......@@ -709,9 +711,12 @@ Network.NetworkLogView = class extends UI.VBox {
nodeCount++;
const requestTransferSize = request.transferSize;
transferSize += requestTransferSize;
const requestResourceSize = request.resourceSize;
resourceSize += requestResourceSize;
if (!node[Network.NetworkLogView._isFilteredOutSymbol]) {
selectedNodeNumber++;
selectedTransferSize += requestTransferSize;
selectedResourceSize += requestResourceSize;
}
const networkManager = SDK.NetworkManager.forRequest(request);
// TODO(allada) inspectedURL should be stored in PageLoad used instead of target so HAR requests can have an
......@@ -748,11 +753,17 @@ Network.NetworkLogView = class extends UI.VBox {
appendChunk(separator);
appendChunk(Common.UIString(
'%s / %s transferred', Number.bytesToString(selectedTransferSize), Number.bytesToString(transferSize)));
appendChunk(separator);
appendChunk(Common.UIString(
'%s / %s resources', Number.bytesToString(selectedResourceSize), Number.bytesToString(resourceSize)));
} else {
appendChunk(Common.UIString('%d requests', nodeCount));
appendChunk(separator);
appendChunk(Common.UIString('%s transferred', Number.bytesToString(transferSize)));
appendChunk(separator);
appendChunk(Common.UIString('%s resources', Number.bytesToString(resourceSize)));
}
if (baseTime !== -1 && maxTime !== -1) {
appendChunk(separator);
appendChunk(Common.UIString('Finish: %s', Number.secondsToString(maxTime - baseTime)));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment