Commit 9dc21ef5 authored by Reilly Grant's avatar Reilly Grant Committed by Commit Bot

Add logging when receiving an invalid frame token

To investigate issue 1045372 some crash keys were added to log the old
and new frame tokens however this doesn't work for the flaky browser
tests I am investigating in issue 1022321. This change adds log messages
which should show up when the test flakes.

Bug: 1022321
Change-Id: If1c88d1cea3dc771c96a4d636b6797a8686b6315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123030
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: default avatarJonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#754145}
parent ede8c5fd
...@@ -35,6 +35,11 @@ void FrameTokenMessageQueue::DidProcessFrame(uint32_t frame_token) { ...@@ -35,6 +35,11 @@ void FrameTokenMessageQueue::DidProcessFrame(uint32_t frame_token) {
base::NumberToString(frame_token)); base::NumberToString(frame_token));
base::debug::DumpWithoutCrashing(); base::debug::DumpWithoutCrashing();
// TODO(reillyg): Remove this once investigation into
// https://crbug.com/1022321 is over.
LOG(ERROR) << "Got invalid frame token: " << frame_token
<< " <= " << last_received_frame_token_;
client_->OnInvalidFrameToken(frame_token); client_->OnInvalidFrameToken(frame_token);
return; return;
} }
...@@ -59,6 +64,10 @@ void FrameTokenMessageQueue::EnqueueOrRunFrameTokenCallback( ...@@ -59,6 +64,10 @@ void FrameTokenMessageQueue::EnqueueOrRunFrameTokenCallback(
base::OnceClosure callback) { base::OnceClosure callback) {
// Zero token is invalid. // Zero token is invalid.
if (!frame_token) { if (!frame_token) {
// TODO(reillyg): Remove this once investigation into
// https://crbug.com/1022321 is over.
LOG(ERROR) << "Got invalid frame token: " << frame_token;
client_->OnInvalidFrameToken(frame_token); client_->OnInvalidFrameToken(frame_token);
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment