Commit 9dd5e2a3 authored by avi's avatar avi Committed by Commit bot

Add a check that the planned replacement for page id for updating the history offset works.

BUG=369661
TEST=All navigation tests remain green.

Review URL: https://codereview.chromium.org/1129913004

Cr-Commit-Position: refs/heads/master@{#329253}
parent faa4ef7f
......@@ -2690,13 +2690,20 @@ void RenderFrameImpl::didCommitProvisionalLoad(
render_view_->history_list_offset_ + 1;
}
} else {
if (navigation_state->request_params().page_id != -1) {
const RequestNavigationParams& request_params =
navigation_state->request_params();
if (request_params.page_id != -1) {
// This is a successful session history navigation!
render_view_->page_id_ = navigation_state->request_params().page_id;
render_view_->page_id_ = request_params.page_id;
render_view_->history_list_offset_ =
navigation_state->request_params().pending_history_list_offset;
request_params.pending_history_list_offset;
}
// Page id is going away (http://crbug.com/369661); ensure that a
// replacement that doesn't use page id is equivalent in all cases.
CHECK_EQ(request_params.page_id != -1,
request_params.nav_entry_id != 0 &&
!request_params.intended_as_new_entry);
}
bool sent = Send(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment