Commit 9dd85832 authored by shrekshao's avatar shrekshao Committed by Commit Bot

Fix MultiDrawInstancedBaseVertexBaseInstance request issue with MultiDraw

Fix the issue where requesting GL_WEBGL_multi_draw_instanced_base_vertex_base_instance
returns null when GL_WEBGL_multi_draw is first requested on passthrough.

TBR=kbr@chromium.org

Bug: 891861
Change-Id: Ib9c15787c8eef79c71d71386a3e1ac4add1f92d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986124Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#728257}
parent b0281b4a
......@@ -30,13 +30,18 @@ bool WebGLMultiDrawInstancedBaseVertexBaseInstance::Supported(
// Logic: IsSupportedByValidating || IsSupportedByPassthroughOnANGLE
// GL_ANGLE_base_vertex_base_instance is removed from supports if we requested
// GL_WEBGL_draw_instanced_base_vertex_base_instance first
// So we need to add a or for
// So we need to add an OR for
// GL_WEBGL_draw_instanced_base_vertex_base_instance
// Same happens for GL_ANGLE_multi_draw if GL_WEBGL_multi_draw is requested
// first
return (context->ExtensionsUtil()->SupportsExtension(
"GL_WEBGL_draw_instanced_base_vertex_base_instance") &&
context->ExtensionsUtil()->SupportsExtension(
"GL_WEBGL_multi_draw_instanced_base_vertex_base_instance")) ||
(context->ExtensionsUtil()->SupportsExtension("GL_ANGLE_multi_draw") &&
((context->ExtensionsUtil()->SupportsExtension(
"GL_ANGLE_multi_draw") ||
context->ExtensionsUtil()->EnsureExtensionEnabled(
"GL_WEBGL_multi_draw")) &&
(context->ExtensionsUtil()->SupportsExtension(
"GL_ANGLE_base_vertex_base_instance") ||
context->ExtensionsUtil()->SupportsExtension(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment