Mark classes with final dtors as final

- -Wfinal-dtor-non-final-class warns on classes with final dtors but
  not final classes.
- Error messages are better when the class is marked final.
- Fix existing issues in code base and a follow up will remove warning
  exemption.

Bug: 999886
Test: no errors building
Change-Id: I6d861d9e63cf93670087e56c80a624d5b69d038c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468789
Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817153}

cc/paint/image_transfer_cache_entry.h

@@ -42,7 +42,7 @@ CC_PAINT_EXPORT size_t NumberOfPlanesForYUVDecodeFormat(YUVDecodeFormat format);
 // Client/ServiceImageTransferCacheEntry implement a transfer cache entry
 // for transferring image data. On the client side, this is a CPU SkPixmap,
 // on the service side the image is uploaded and is a GPU SkImage.
-class CC_PAINT_EXPORT ClientImageTransferCacheEntry
+class CC_PAINT_EXPORT ClientImageTransferCacheEntry final
     : public ClientTransferCacheEntryBase<TransferCacheEntryType::kImage> {
  public:
   explicit ClientImageTransferCacheEntry(const SkPixmap* pixmap,
@@ -90,7 +90,7 @@ class CC_PAINT_EXPORT ClientImageTransferCacheEntry
   void ValidateYUVDataBeforeSerializing() const;
 };
 
-class CC_PAINT_EXPORT ServiceImageTransferCacheEntry
+class CC_PAINT_EXPORT ServiceImageTransferCacheEntry final
     : public ServiceTransferCacheEntryBase<TransferCacheEntryType::kImage> {
  public:
   ServiceImageTransferCacheEntry();

cc/paint/raw_memory_transfer_cache_entry.h

@@ -15,7 +15,7 @@ namespace cc {
 // Client/ServiceRawMemoryTransferCacheEntry implement a transfer cache entry
 // backed by raw memory, with no conversion during serialization or
 // deserialization.
-class CC_PAINT_EXPORT ClientRawMemoryTransferCacheEntry
+class CC_PAINT_EXPORT ClientRawMemoryTransferCacheEntry final
     : public ClientTransferCacheEntryBase<TransferCacheEntryType::kRawMemory> {
  public:
   explicit ClientRawMemoryTransferCacheEntry(std::vector<uint8_t> data);
@@ -30,7 +30,7 @@ class CC_PAINT_EXPORT ClientRawMemoryTransferCacheEntry
   static base::AtomicSequenceNumber s_next_id_;
 };
 
-class CC_PAINT_EXPORT ServiceRawMemoryTransferCacheEntry
+class CC_PAINT_EXPORT ServiceRawMemoryTransferCacheEntry final
     : public ServiceTransferCacheEntryBase<TransferCacheEntryType::kRawMemory> {
  public:
   ServiceRawMemoryTransferCacheEntry();

cc/paint/shader_transfer_cache_entry.h

@@ -22,7 +22,7 @@ namespace cc {
 // image) and that the design complication for this edge case isn't worth
 // it.
 
-class CC_PAINT_EXPORT ServiceShaderTransferCacheEntry
+class CC_PAINT_EXPORT ServiceShaderTransferCacheEntry final
     : public ServiceTransferCacheEntryBase<TransferCacheEntryType::kShader> {
  public:
   explicit ServiceShaderTransferCacheEntry(sk_sp<PaintShader> shader,

cc/paint/skottie_transfer_cache_entry.h

@@ -15,7 +15,7 @@ class SkottieWrapper;
 
 // Client/ServiceSkottieTransferCacheEntry implements a transfer cache entry
 // for transferring skottie data.
-class CC_PAINT_EXPORT ClientSkottieTransferCacheEntry
+class CC_PAINT_EXPORT ClientSkottieTransferCacheEntry final
     : public ClientTransferCacheEntryBase<TransferCacheEntryType::kSkottie> {
  public:
   explicit ClientSkottieTransferCacheEntry(
@@ -32,7 +32,7 @@ class CC_PAINT_EXPORT ClientSkottieTransferCacheEntry
   scoped_refptr<SkottieWrapper> skottie_;
 };
 
-class CC_PAINT_EXPORT ServiceSkottieTransferCacheEntry
+class CC_PAINT_EXPORT ServiceSkottieTransferCacheEntry final
     : public ServiceTransferCacheEntryBase<TransferCacheEntryType::kSkottie> {
  public:
   ServiceSkottieTransferCacheEntry();

cc/raster/staging_buffer_pool.h

@@ -77,7 +77,7 @@ struct StagingBuffer {
   uint64_t content_id = 0;
 };
 
-class CC_EXPORT StagingBufferPool
+class CC_EXPORT StagingBufferPool final
     : public base::trace_event::MemoryDumpProvider {
  public:
   StagingBufferPool(scoped_refptr<base::SequencedTaskRunner> task_runner,