Commit 9ded52ff authored by Peter Kasting's avatar Peter Kasting Committed by Commit Bot

Widget unittest cleanup part 1: Delete redundant test.

This test is line-for-line identical with the test below it.

Long ago these two differed.  They don't anymore, so nuke one.

Bug: none
Change-Id: I80c11632589cb8e781fd4a272eb4540c37129f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143516
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: default avatarThomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757862}
parent a8afa1b1
...@@ -343,28 +343,7 @@ class OwnershipTestWidget : public Widget { ...@@ -343,28 +343,7 @@ class OwnershipTestWidget : public Widget {
// TODO(sky): add coverage of ownership for the desktop variants. // TODO(sky): add coverage of ownership for the desktop variants.
// Widget owns its NativeWidget, part 1: NativeWidget is a platform-native // Widget owns its NativeWidget, part 1.
// widget.
TEST_F(WidgetOwnershipTest, Ownership_WidgetOwnsPlatformNativeWidget) {
OwnershipTestState state;
auto widget = std::make_unique<OwnershipTestWidget>(&state);
Widget::InitParams params = CreateParamsForTestWidget();
params.native_widget = CreatePlatformNativeWidgetImpl(
params, widget.get(), kStubCapture, &state.native_widget_deleted);
widget->Init(std::move(params));
// Now delete the Widget, which should delete the NativeWidget.
widget.reset();
EXPECT_TRUE(state.widget_deleted);
EXPECT_TRUE(state.native_widget_deleted);
// TODO(beng): write test for this ownership scenario and the NativeWidget
// being deleted out from under the Widget.
}
// Widget owns its NativeWidget, part 2: NativeWidget is a NativeWidget.
TEST_F(WidgetOwnershipTest, Ownership_WidgetOwnsViewsNativeWidget) { TEST_F(WidgetOwnershipTest, Ownership_WidgetOwnsViewsNativeWidget) {
OwnershipTestState state; OwnershipTestState state;
...@@ -384,8 +363,7 @@ TEST_F(WidgetOwnershipTest, Ownership_WidgetOwnsViewsNativeWidget) { ...@@ -384,8 +363,7 @@ TEST_F(WidgetOwnershipTest, Ownership_WidgetOwnsViewsNativeWidget) {
// being deleted out from under the Widget. // being deleted out from under the Widget.
} }
// Widget owns its NativeWidget, part 3: NativeWidget is a NativeWidget, // Widget owns its NativeWidget, part 2: destroy the parent view.
// destroy the parent view.
TEST_F(WidgetOwnershipTest, TEST_F(WidgetOwnershipTest,
Ownership_WidgetOwnsViewsNativeWidget_DestroyParentView) { Ownership_WidgetOwnsViewsNativeWidget_DestroyParentView) {
OwnershipTestState state; OwnershipTestState state;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment