Skip to content

GitLab

T
tangled
Commit 9df515c0 authored by Xiaocheng Hu's avatar Xiaocheng Hu Committed by Commit Bot
Browse files
Options

[Sheriff] Disable two DiceSigninUiUtilTest on Windows 

The following two tests are timing out on Windows

DiceSigninUiUtilTest.GetAccountsForDicePromos
DiceSigninUiUtilTest.ShouldShowAnimatedIdentityOnOpeningWindow_ReturnsFalseForSingleProfileSingleSignin

See https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29/62809

Bug: 1014790
Change-Id: I1f3dc81f3aff11e22a9ac767809c857a20cd3169
NoTry: True
Tbr: droger@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982838Reviewed-by: default avatarXiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727574}
parent 8c5e01d1
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 4 deletions
chrome/browser/signin/signin_ui_util_unittest.cc
View file @ 9df515c0
...@@ -471,8 +471,8 @@ TEST_F(DiceSigninUiUtilTest, MAYBE_EnableSyncForNewAccountWithOneTab) { ...@@ -471,8 +471,8 @@ TEST_F(DiceSigninUiUtilTest, MAYBE_EnableSyncForNewAccountWithOneTab) {
active_contents->GetVisibleURL()); active_contents->GetVisibleURL());
} }
// TODO(https://crbug.com/1014790): Timeout on Mac10.12. // TODO(https://crbug.com/1014790): Timeout on Mac10.12 and Win7 x64.
#if defined(OS_MACOSX) #if defined(OS_MACOSX) || defined(OS_WIN)
#define MAYBE_GetAccountsForDicePromos DISABLED_GetAccountsForDicePromos #define MAYBE_GetAccountsForDicePromos DISABLED_GetAccountsForDicePromos
#else #else
#define MAYBE_GetAccountsForDicePromos GetAccountsForDicePromos #define MAYBE_GetAccountsForDicePromos GetAccountsForDicePromos
...@@ -568,8 +568,8 @@ TEST_F( ...@@ -568,8 +568,8 @@ TEST_F(
*profile_manager()->profile_attributes_storage(), profile())); *profile_manager()->profile_attributes_storage(), profile()));
} }
// TODO(https://crbug.com/1014790): Timeout on Mac10.12. // TODO(https://crbug.com/1014790): Timeout on Mac10.12 and Win7 x64.
#if defined(OS_MACOSX) #if defined(OS_MACOSX) || defined(OS_WIN)
#define MAYBE_ShouldShowAnimatedIdentityOnOpeningWindow_ReturnsFalseForSingleProfileSingleSignin \ #define MAYBE_ShouldShowAnimatedIdentityOnOpeningWindow_ReturnsFalseForSingleProfileSingleSignin \
DISABLED_ShouldShowAnimatedIdentityOnOpeningWindow_ReturnsFalseForSingleProfileSingleSignin DISABLED_ShouldShowAnimatedIdentityOnOpeningWindow_ReturnsFalseForSingleProfileSingleSignin
#else #else
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment