Enable app info dialog by default.

This dialog is very usable and is ready to be enabled by default to get
wider exposure.

BUG=266739

Review URL: https://codereview.chromium.org/312423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275679 0039d316-1c4b-4281-b951-d872f2087c98

chrome/app/generated_resources.grd

@@ -6306,11 +6306,11 @@ Keep your key file in a safe place. You will need it to create new versions of y
         <message name="IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH_DESCRIPTION" desc="Description of the flag to disable voice search in the app list.">
           Disable voice search in the App Launcher. If disabled, the user won't be able to search by speech.
         </message>
-        <message name="IDS_FLAGS_ENABLE_APP_INFO_IN_APP_LIST" desc="Name of the flag to enable the app info context menu option in the app list.">
-          Enable the app info dialog.
+        <message name="IDS_FLAGS_DISABLE_APP_INFO_IN_APP_LIST" desc="Name of the flag to disable the app info context menu option in the app list.">
+          Disable the app info dialog.
         </message>
-        <message name="IDS_FLAGS_ENABLE_APP_INFO_IN_APP_LIST_DESCRIPTION" desc="Description of the flag to enable the app info context menu option in the app list.">
-          Enable the app info dialog. If enabled, the user will be able to select the 'App Info' context menu in the App Launcher to show the app info dialog for the selected app.
+        <message name="IDS_FLAGS_DISABLE_APP_INFO_IN_APP_LIST_DESCRIPTION" desc="Description of the flag to disable the app info context menu option in the app list.">
+          Disable the app info dialog. If not disabled, the user will be able to select the 'App Info' context menu in the App Launcher to show the app info dialog for the selected app.
        </message>
         <message name="IDS_FLAGS_ENABLE_EXPERIMENTAL_APP_LIST_NAME" desc="Name of the flag to enable the experimental app launcher.">
           Enable the experimental App Launcher.

chrome/browser/about_flags.cc

@@ -1471,6 +1471,13 @@ const Experiment kExperiments[] = {
     SINGLE_VALUE_TYPE(switches::kEnableAppList)
   },
 #endif
+  {
+    "disable-app-list-app-info",
+    IDS_FLAGS_DISABLE_APP_INFO_IN_APP_LIST,
+    IDS_FLAGS_DISABLE_APP_INFO_IN_APP_LIST_DESCRIPTION,
+    kOsLinux | kOsWin | kOsCrOS,
+    SINGLE_VALUE_TYPE(app_list::switches::kDisableAppInfo)
+  },
   {
     "disable-app-list-voice-search",
     IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH,
@@ -1478,13 +1485,6 @@ const Experiment kExperiments[] = {
     kOsCrOS,
     SINGLE_VALUE_TYPE(app_list::switches::kDisableVoiceSearch)
   },
-  {
-    "enable-app-list-app-info",
-    IDS_FLAGS_ENABLE_APP_INFO_IN_APP_LIST,
-    IDS_FLAGS_ENABLE_APP_INFO_IN_APP_LIST_DESCRIPTION,
-    kOsLinux | kOsWin | kOsCrOS,
-    SINGLE_VALUE_TYPE(app_list::switches::kEnableAppInfo)
-  },
 #endif
 #if defined(OS_ANDROID)
   {

chrome/browser/ui/app_list/app_list_service_views_browsertest.cc

@@ -96,7 +96,6 @@ class AppListControllerAppInfoDialogBrowserTest : public ExtensionBrowserTest {
 
   virtual void SetUpCommandLine(base::CommandLine* command_line) OVERRIDE {
     ExtensionBrowserTest::SetUpCommandLine(command_line);
-    command_line->AppendSwitch(app_list::switches::kEnableAppInfo);
   }
 
  private:

ui/app_list/app_list_switches.cc

@@ -9,15 +9,15 @@
 namespace app_list {
 namespace switches {
 
+// If set, the app info context menu item is not available in the app list UI.
+const char kDisableAppInfo[] = "disable-app-list-app-info";
+
 // Disables syncing of the app list independent of extensions.
 const char kDisableSyncAppList[] = "disable-sync-app-list";
 
 // If set, the voice search is disabled in app list UI.
 const char kDisableVoiceSearch[] = "disable-app-list-voice-search";
 
-// If set, the app info context menu item is available in the app list UI.
-const char kEnableAppInfo[] = "enable-app-list-app-info";
-
 // If set, the app list will be centered and wide instead of tall.
 const char kEnableCenteredAppList[] = "enable-centered-app-list";
 
@@ -55,7 +55,7 @@ bool IsVoiceSearchEnabled() {
 }
 
 bool IsAppInfoEnabled() {
-  return CommandLine::ForCurrentProcess()->HasSwitch(kEnableAppInfo);
+  return !CommandLine::ForCurrentProcess()->HasSwitch(kDisableAppInfo);
 }
 
 bool IsExperimentalAppListEnabled() {

ui/app_list/app_list_switches.h

@@ -11,9 +11,9 @@ namespace app_list {
 namespace switches {
 
 // Please keep these flags sorted.
+APP_LIST_EXPORT extern const char kDisableAppInfo[];
 APP_LIST_EXPORT extern const char kDisableSyncAppList[];
 APP_LIST_EXPORT extern const char kDisableVoiceSearch[];
-APP_LIST_EXPORT extern const char kEnableAppInfo[];
 APP_LIST_EXPORT extern const char kEnableCenteredAppList[];
 APP_LIST_EXPORT extern const char kEnableExperimentalAppList[];
 APP_LIST_EXPORT extern const char kEnableHotwordAlwaysOn[];