[layoutng] Avoid recomputing the ICB size where we can

It's somewhat expensive to compute it.

R=mstensho@chromium.org,ikilpatrick@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ic1fc1b7b2e11c18a96a268fb731716d074940a36
Reviewed-on: https://chromium-review.googlesource.com/1235213Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592842}

third_party/blink/renderer/core/layout/ng/ng_block_node.cc

@@ -130,9 +130,9 @@ void UpdateLegacyMultiColumnFlowThread(
 }
 
 NGConstraintSpaceBuilder CreateConstraintSpaceBuilderForMinMax(
-    NGBlockNode node) {
-  return NGConstraintSpaceBuilder(node.Style().GetWritingMode(),
-                                  node.InitialContainingBlockSize())
+    NGBlockNode node,
+    NGPhysicalSize icb_size) {
+  return NGConstraintSpaceBuilder(node.Style().GetWritingMode(), icb_size)
       .SetTextDirection(node.Style().Direction())
       .SetIsIntermediateLayout(true)
       .SetIsNewFormattingContext(node.CreatesNewFormattingContext())
@@ -323,9 +323,12 @@ MinMaxSize NGBlockNode::ComputeMinMaxSize(
     return ComputeMinMaxSizeFromLegacy(input.size_type);
   }
 
+  NGPhysicalSize icb_size = constraint_space
+                                ? constraint_space->InitialContainingBlockSize()
+                                : InitialContainingBlockSize();
   NGConstraintSpace zero_constraint_space =
-      CreateConstraintSpaceBuilderForMinMax(*this).ToConstraintSpace(
-          Style().GetWritingMode());
+      CreateConstraintSpaceBuilderForMinMax(*this, icb_size)
+          .ToConstraintSpace(Style().GetWritingMode());
 
   if (!constraint_space) {
     // Using the zero-sized constraint space when measuring for an orthogonal
@@ -378,7 +381,7 @@ MinMaxSize NGBlockNode::ComputeMinMaxSize(
 
   // Now, redo with infinite space for max_content
   NGConstraintSpace infinite_constraint_space =
-      CreateConstraintSpaceBuilderForMinMax(*this)
+      CreateConstraintSpaceBuilderForMinMax(*this, icb_size)
           .SetAvailableSize({LayoutUnit::Max(), LayoutUnit()})
           .SetPercentageResolutionSize({LayoutUnit(), LayoutUnit()})
           .ToConstraintSpace(Style().GetWritingMode());