Commit 9e39b76c authored by Sigurdur Asgeirsson's avatar Sigurdur Asgeirsson Committed by Commit Bot

DumpWithoutCrashing after computing values to report, not before.

As-is the crash dumps don't contain the computed values, which isn't
very useful.

Bug: 1017827
Change-Id: I6ebf14417795744020eb5a560287bc45eb45722b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932164
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718707}
parent c2bf366d
...@@ -47,11 +47,6 @@ NOINLINE void MaybeDumpWithoutCrashing( ...@@ -47,11 +47,6 @@ NOINLINE void MaybeDumpWithoutCrashing(
// against concurrent quota overruns on multiple threads, but that's fine. // against concurrent quota overruns on multiple threads, but that's fine.
have_crashed = true; have_crashed = true;
// This is happening because the user of the interface implicated on the crash
// stack has queued up an unreasonable number of messages, namely
// |quota_used|.
base::debug::DumpWithoutCrashing();
size_t local_quota_used = total_quota_used; size_t local_quota_used = total_quota_used;
bool had_message_pipe = false; bool had_message_pipe = false;
if (message_pipe_quota_used.has_value()) { if (message_pipe_quota_used.has_value()) {
...@@ -62,6 +57,11 @@ NOINLINE void MaybeDumpWithoutCrashing( ...@@ -62,6 +57,11 @@ NOINLINE void MaybeDumpWithoutCrashing(
base::debug::Alias(&total_quota_used); base::debug::Alias(&total_quota_used);
base::debug::Alias(&local_quota_used); base::debug::Alias(&local_quota_used);
base::debug::Alias(&had_message_pipe); base::debug::Alias(&had_message_pipe);
// This is happening because the user of the interface implicated on the crash
// stack has queued up an unreasonable number of messages, namely
// |quota_used|.
base::debug::DumpWithoutCrashing();
} }
} // namespace } // namespace
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment