Commit 9e422ecc authored by tfarina@chromium.org's avatar tfarina@chromium.org

Move BookmarkStorage into bookmarks namespace.

BUG=370433
TEST=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/299403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273057 0039d316-1c4b-4281-b951-d872f2087c98
parent 3b6df02b
...@@ -26,6 +26,8 @@ ...@@ -26,6 +26,8 @@
#include "ui/gfx/favicon_size.h" #include "ui/gfx/favicon_size.h"
using base::Time; using base::Time;
using bookmarks::BookmarkLoadDetails;
using bookmarks::BookmarkStorage;
namespace { namespace {
......
...@@ -25,9 +25,7 @@ ...@@ -25,9 +25,7 @@
class BookmarkExpandedStateTracker; class BookmarkExpandedStateTracker;
class BookmarkIndex; class BookmarkIndex;
class BookmarkLoadDetails;
class BookmarkModelObserver; class BookmarkModelObserver;
class BookmarkStorage;
struct BookmarkMatch; struct BookmarkMatch;
class PrefService; class PrefService;
class ScopedGroupBookmarkActions; class ScopedGroupBookmarkActions;
...@@ -38,6 +36,8 @@ class SequencedTaskRunner; ...@@ -38,6 +36,8 @@ class SequencedTaskRunner;
} }
namespace bookmarks { namespace bookmarks {
class BookmarkLoadDetails;
class BookmarkStorage;
class ScopedGroupBookmarkActions; class ScopedGroupBookmarkActions;
} }
...@@ -285,7 +285,7 @@ class BookmarkModel : public BookmarkService { ...@@ -285,7 +285,7 @@ class BookmarkModel : public BookmarkService {
private: private:
friend class BookmarkCodecTest; friend class BookmarkCodecTest;
friend class BookmarkModelTest; friend class BookmarkModelTest;
friend class BookmarkStorage; friend class bookmarks::BookmarkStorage;
friend class bookmarks::ScopedGroupBookmarkActions; friend class bookmarks::ScopedGroupBookmarkActions;
friend class test::TestBookmarkClient; friend class test::TestBookmarkClient;
...@@ -309,7 +309,7 @@ class BookmarkModel : public BookmarkService { ...@@ -309,7 +309,7 @@ class BookmarkModel : public BookmarkService {
// Invoked when loading is finished. Sets |loaded_| and notifies observers. // Invoked when loading is finished. Sets |loaded_| and notifies observers.
// BookmarkModel takes ownership of |details|. // BookmarkModel takes ownership of |details|.
void DoneLoading(scoped_ptr<BookmarkLoadDetails> details); void DoneLoading(scoped_ptr<bookmarks::BookmarkLoadDetails> details);
// Populates |nodes_ordered_by_url_set_| from root. // Populates |nodes_ordered_by_url_set_| from root.
void PopulateNodesByURL(BookmarkNode* node); void PopulateNodesByURL(BookmarkNode* node);
...@@ -373,7 +373,7 @@ class BookmarkModel : public BookmarkService { ...@@ -373,7 +373,7 @@ class BookmarkModel : public BookmarkService {
// Creates and returns a new BookmarkLoadDetails. It's up to the caller to // Creates and returns a new BookmarkLoadDetails. It's up to the caller to
// delete the returned object. // delete the returned object.
scoped_ptr<BookmarkLoadDetails> CreateLoadDetails( scoped_ptr<bookmarks::BookmarkLoadDetails> CreateLoadDetails(
const std::string& accept_languages); const std::string& accept_languages);
BookmarkClient* const client_; BookmarkClient* const client_;
...@@ -407,7 +407,7 @@ class BookmarkModel : public BookmarkService { ...@@ -407,7 +407,7 @@ class BookmarkModel : public BookmarkService {
base::CancelableTaskTracker cancelable_task_tracker_; base::CancelableTaskTracker cancelable_task_tracker_;
// Reads/writes bookmarks to disk. // Reads/writes bookmarks to disk.
scoped_refptr<BookmarkStorage> store_; scoped_refptr<bookmarks::BookmarkStorage> store_;
scoped_ptr<BookmarkIndex> index_; scoped_ptr<BookmarkIndex> index_;
......
...@@ -20,6 +20,8 @@ ...@@ -20,6 +20,8 @@
using base::TimeTicks; using base::TimeTicks;
namespace bookmarks {
namespace { namespace {
// Extension used for backup files (copy of main file created during startup). // Extension used for backup files (copy of main file created during startup).
...@@ -185,3 +187,5 @@ bool BookmarkStorage::SaveNow() { ...@@ -185,3 +187,5 @@ bool BookmarkStorage::SaveNow() {
writer_.WriteNow(data); writer_.WriteNow(data);
return true; return true;
} }
} // namespace bookmarks
...@@ -18,6 +18,8 @@ namespace base { ...@@ -18,6 +18,8 @@ namespace base {
class SequencedTaskRunner; class SequencedTaskRunner;
} }
namespace bookmarks {
// BookmarkLoadDetails is used by BookmarkStorage when loading bookmarks. // BookmarkLoadDetails is used by BookmarkStorage when loading bookmarks.
// BookmarkModel creates a BookmarkLoadDetails and passes it (including // BookmarkModel creates a BookmarkLoadDetails and passes it (including
// ownership) to BookmarkStorage. BookmarkStorage loads the bookmarks (and // ownership) to BookmarkStorage. BookmarkStorage loads the bookmarks (and
...@@ -163,4 +165,6 @@ class BookmarkStorage : public base::ImportantFileWriter::DataSerializer, ...@@ -163,4 +165,6 @@ class BookmarkStorage : public base::ImportantFileWriter::DataSerializer,
DISALLOW_COPY_AND_ASSIGN(BookmarkStorage); DISALLOW_COPY_AND_ASSIGN(BookmarkStorage);
}; };
} // namespace bookmarks
#endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_STORAGE_H_ #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_STORAGE_H_
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment