Commit 9e4702df authored by brettw@chromium.org's avatar brettw@chromium.org

Fix resolving loop in GN

This loop doesn't loop over all items. Originally I was inserting the new items at the end and this made sense, but then decided to insert them in the middle and the loop length computations were off.

BUG=
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/314283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275830 0039d316-1c4b-4281-b951-d872f2087c98
parent a10299d3
......@@ -102,8 +102,7 @@ void Target::OnResolved() {
// group's deps. We insert the new deps immediately after the group so that
// the ordering is preserved. We need to keep the original group so that any
// flags, etc. that it specifies itself are applied to us.
size_t original_deps_size = deps_.size();
for (size_t i = 0; i < original_deps_size; i++) {
for (size_t i = 0; i < deps_.size(); i++) {
const Target* dep = deps_[i].ptr;
if (dep->output_type_ == GROUP) {
deps_.insert(deps_.begin() + i + 1, dep->deps_.begin(), dep->deps_.end());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment