Commit 9e47bdb2 authored by sczs's avatar sczs Committed by Commit Bot

[ios] Fixes InfobarBannerDismissal animation.

This regression was introduced here:
https://chromium-review.googlesource.com/c/chromium/src/+/1974894

We need to respect the animated flag, this is really hard to test
since we can't tell on eg if the dismissal was animated or not.

Bug: 1049088
Change-Id: I9e4326f4fb7885146191bd39e9ebeded8c1c9ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067642
Auto-Submit: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: default avatarChris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743443}
parent c1240bf3
......@@ -446,7 +446,7 @@ const CGFloat kBannerOverlapWithOmnibox = 5.0;
self.baseViewController.presentedViewController ==
self.bannerViewController) {
[self infobarBannerWillBeDismissed:userInitiated];
[self.baseViewController dismissViewControllerAnimated:YES
[self.baseViewController dismissViewControllerAnimated:animated
completion:completion];
} else if (completion) {
completion();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment