Commit 9e542de9 authored by Sara Kato's avatar Sara Kato Committed by Commit Bot

Update comment terminology in c/b/c/arc/a11y/.*

Update comments to follow convetions mentioned in
https://developers.google.com/style/inclusive-documentation.

Also perform some refactoring of other comments to ensure consistency/
readability.

Bug: 842296
Test: N/A
Change-Id: I389463cc5ccd8f21983ee83383df07521c58aa07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265695
Commit-Queue: Sara Kato <sarakato@chromium.org>
Commit-Queue: Hiroki Sato <hirokisato@chromium.org>
Auto-Submit: Sara Kato <sarakato@chromium.org>
Reviewed-by: default avatarHiroki Sato <hirokisato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782225}
parent 477d8e67
......@@ -431,7 +431,7 @@ void AccessibilityNodeInfoDataWrapper::Serialize(
state_description);
} else {
// TODO(sahok): Append strings anotated as kDescription(which is now
// overwritten)
// overwritten).
out_data->AddStringAttribute(ax::mojom::StringAttribute::kDescription,
state_description);
}
......
......@@ -547,8 +547,9 @@ void ArcAccessibilityHelperBridge::OnNotificationSurfaceAdded(
// notification updated. As order of OnNotificationSurfaceAdded call is not
// guaranteed, we are dispatching the event in both
// ArcAccessibilityHelperBridge and ArcNotificationContentView. The event
// needs to be dispatched after 1. ax tree id is set to the surface, 2 the
// surface is attached to the content view.
// needs to be dispatched after:
// 1. ax_tree_id is set to the surface
// 2. the surface is attached to the content view
if (surface->IsAttached()) {
surface->GetAttachedHost()->NotifyAccessibilityEvent(
ax::mojom::Event::kChildrenChanged, false);
......
......@@ -42,8 +42,8 @@ class ArcBridgeService;
arc::mojom::CaptionStylePtr GetCaptionStyleFromPrefs(PrefService* prefs);
// ArcAccessibilityHelperBridge is an instance to receive converted Android
// accessibility events and info via mojo interface and dispatch them to chrome
// os components.
// accessibility events and info via mojo interface and dispatch them to Chrome
// OS components.
class ArcAccessibilityHelperBridge
: public KeyedService,
public mojom::AccessibilityHelperHost,
......
......@@ -172,7 +172,7 @@ std::string ToLiveStatusString(mojom::AccessibilityLiveRegionType type) {
default:
NOTREACHED();
}
return std::string(); // Dummy.
return std::string(); // Placeholder.
}
} // namespace arc
......@@ -349,7 +349,7 @@ TEST_F(AXTreeSourceArcTest, ReorderChildrenByLayout) {
EXPECT_EQ(10, GetDispatchedEventCount(ax::mojom::Event::kFocus));
// Sanity check tree output.
// Check completeness of tree output.
ExpectTree(
"id=100 window FOCUSABLE (0, 0)-(0, 0) modal=true child_ids=10\n"
" id=10 genericContainer INVISIBLE (0, 0)-(0, 0) restriction=disabled "
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment