Commit 9e54b0c7 authored by Matthew Jones's avatar Matthew Jones Committed by Commit Bot

Set app menu shows from bottom after creation

This is a speculative fix for the app menu appearing off-screen. The
idea is that in some cases the bottom toolbar is initialized before
the app menu handler is (thus the flag to show from the bottom is
never set). This patch sets the value in both places so the order
doesn't matter.

Bug: 894555
Change-Id: I1faac37492e187896fff519ea7f1bf737605c8ae
Reviewed-on: https://chromium-review.googlesource.com/c/1306493Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603655}
parent 5444910b
......@@ -1290,6 +1290,7 @@ public class ToolbarManager implements ToolbarTabController, UrlFocusChangeListe
}
});
mAppMenuButtonHelper = new AppMenuButtonHelper(menuHandler);
mAppMenuButtonHelper.setMenuShowsFromBottom(mBottomToolbarCoordinator != null);
mAppMenuButtonHelper.setOnAppMenuShownListener(() -> {
RecordUserAction.record("MobileToolbarShowMenu");
mToolbar.onMenuShown();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment