Commit 9e5925fc authored by rbpotter's avatar rbpotter Committed by Commit Bot

Print Preview: Remove dead code in CreateCloudPrintSigninTab()

Mirror only exists on Chrome OS, which doesn't have the avatar row.
https://chromium-review.googlesource.com/c/chromium/src/+/1763413
added the correct handling for the Chrome OS case, so per
https://crbug.com/982641#c28 this code never executes.

TBR=sinhak@chromium.org

Bug: 982641
Change-Id: I00e810d16c5a8c61a5fd846c9e6041f28b489bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145092
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758116}
parent 841aca1b
......@@ -9,12 +9,9 @@
#include "base/threading/thread_task_runner_handle.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/account_consistency_mode_manager.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "components/cloud_devices/common/cloud_devices_urls.h"
#include "components/google/core/common/google_util.h"
#include "components/signin/public/base/signin_metrics.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/web_contents.h"
......@@ -65,25 +62,15 @@ void CreateCloudPrintSigninTab(Browser* browser,
bool add_account,
base::OnceClosure callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (AccountConsistencyModeManager::IsMirrorEnabledForProfile(
browser->profile())) {
browser->window()->ShowAvatarBubbleFromAvatarButton(
add_account ? BrowserWindow::AVATAR_BUBBLE_MODE_ADD_ACCOUNT
: BrowserWindow::AVATAR_BUBBLE_MODE_SIGNIN,
signin_metrics::AccessPoint::ACCESS_POINT_CLOUD_PRINT, false);
} else {
GURL url = add_account ? cloud_devices::GetCloudPrintAddAccountURL()
: cloud_devices::GetCloudPrintSigninURL();
content::WebContents* web_contents =
browser->OpenURL(content::OpenURLParams(
google_util::AppendGoogleLocaleParam(
url, g_browser_process->GetApplicationLocale()),
content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));
// This observer will delete itself after destroying the WebContents.
new SignInObserver(web_contents, std::move(callback));
}
GURL url = add_account ? cloud_devices::GetCloudPrintAddAccountURL()
: cloud_devices::GetCloudPrintSigninURL();
content::WebContents* web_contents = browser->OpenURL(content::OpenURLParams(
google_util::AppendGoogleLocaleParam(
url, g_browser_process->GetApplicationLocale()),
content::Referrer(), WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));
// This observer will delete itself after destroying the WebContents.
new SignInObserver(web_contents, std::move(callback));
}
} // namespace print_dialog_cloud
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment