Commit 9e6f7bbe authored by Robert Ogden's avatar Robert Ogden Committed by Commit Bot

Fix IsolatedPrerender misnamed canary check

Bug: 1134643
Change-Id: Ia5fb8a67ae27436b8ec6bf6bbb5dd051944d3a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446197Reviewed-by: default avatarRyan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813321}
parent 5788ad18
...@@ -2335,10 +2335,17 @@ IN_PROC_BROWSER_TEST_F( ...@@ -2335,10 +2335,17 @@ IN_PROC_BROWSER_TEST_F(
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
ProbingEnabled_CanaryOn_TLSCanaryGood_DNSCanaryBad_IsolatedPrerenderBrowserTest, ProbingEnabled_CanaryOn_TLSCanaryGood_DNSCanaryBad_IsolatedPrerenderBrowserTest,
DISABLE_ON_WIN_MAC_CHROMEOS(DNSProbeOK)) { DISABLE_ON_WIN_MAC_CHROMEOS(DNSProbeOK)) {
base::HistogramTester histogram_tester;
RunProbeTest(/*probe_success=*/true, RunProbeTest(/*probe_success=*/true,
/*expect_successful_tls_probe=*/false, /*expect_successful_tls_probe=*/false,
/*expected_status=*/1, /*expected_status=*/1,
/*expect_probe=*/true); /*expect_probe=*/true);
histogram_tester.ExpectTotalCount(
"Availability.Prober.FinalState.IsolatedPrerenderDNSCanaryCheck", 1);
histogram_tester.ExpectTotalCount(
"Availability.Prober.FinalState.IsolatedPrerenderTLSCanaryCheck", 1);
} }
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
...@@ -2353,10 +2360,17 @@ IN_PROC_BROWSER_TEST_F( ...@@ -2353,10 +2360,17 @@ IN_PROC_BROWSER_TEST_F(
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
ProbingEnabled_CanaryOn_TLSCanaryBad_DNSCanaryBad_IsolatedPrerenderBrowserTest, ProbingEnabled_CanaryOn_TLSCanaryBad_DNSCanaryBad_IsolatedPrerenderBrowserTest,
DISABLE_ON_WIN_MAC_CHROMEOS(TLSProbeOK)) { DISABLE_ON_WIN_MAC_CHROMEOS(TLSProbeOK)) {
base::HistogramTester histogram_tester;
RunProbeTest(/*probe_success=*/true, RunProbeTest(/*probe_success=*/true,
/*expect_successful_tls_probe=*/true, /*expect_successful_tls_probe=*/true,
/*expected_status=*/1, /*expected_status=*/1,
/*expect_probe=*/true); /*expect_probe=*/true);
histogram_tester.ExpectTotalCount(
"Availability.Prober.FinalState.IsolatedPrerenderDNSCanaryCheck", 1);
histogram_tester.ExpectTotalCount(
"Availability.Prober.FinalState.IsolatedPrerenderTLSCanaryCheck", 1);
} }
IN_PROC_BROWSER_TEST_F( IN_PROC_BROWSER_TEST_F(
......
...@@ -297,7 +297,7 @@ IsolatedPrerenderOriginProber::IsolatedPrerenderOriginProber(Profile* profile) ...@@ -297,7 +297,7 @@ IsolatedPrerenderOriginProber::IsolatedPrerenderOriginProber(Profile* profile)
content::BrowserContext::GetDefaultStoragePartition(profile_) content::BrowserContext::GetDefaultStoragePartition(profile_)
->GetURLLoaderFactoryForBrowserProcess(), ->GetURLLoaderFactoryForBrowserProcess(),
profile_->GetPrefs(), profile_->GetPrefs(),
AvailabilityProber::ClientName::kIsolatedPrerenderTLSCanaryCheck, AvailabilityProber::ClientName::kIsolatedPrerenderDNSCanaryCheck,
IsolatedPrerenderDNSCanaryCheckURL(), IsolatedPrerenderDNSCanaryCheckURL(),
AvailabilityProber::HttpMethod::kGet, net::HttpRequestHeaders(), AvailabilityProber::HttpMethod::kGet, net::HttpRequestHeaders(),
retry_policy, timeout_policy, traffic_annotation, retry_policy, timeout_policy, traffic_annotation,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment