Skip to content

GitLab

T
tangled
Commit 9e80a88e authored by Robert Ma's avatar Robert Ma Committed by Commit Bot
Browse files
Options

Fix incorrect uses of testdriver.js in WPT 

testdriver-vendor.js must be included after testdriver.js.
This CL fixes all the affected tests; there will be a new lint rule to
prevent regressions later.

Bug: 1105751
Change-Id: I793c5d3c65f4cdeeed3f120f6fad063dffaaa406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300261
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: default avatarEric Willigers <ericwilligers@chromium.org>
Auto-Submit: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#788828}
parent 26aef835
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 18 deletions
third_party/blink/web_tests/TestExpectations
View file @ 9e80a88e
......@@ -2694,6 +2694,8 @@ crbug.com/1100119 [ Mac ] external/wpt/css/css-pseudo/active-selection-053.html
crbug.com/1100119 [ Mac ] external/wpt/css/css-pseudo/active-selection-054.html [ Failure ]
crbug.com/1018465 external/wpt/css/css-pseudo/active-selection-056.html [ Failure ]
crbug.com/1105958 external/wpt/payment-request/payment-is-showing.https.html [ Timeout ]
# ====== New tests from wpt-importer added here ======
crbug.com/626703 [ Linux ] virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-gutters-014.html [ Failure ]
crbug.com/626703 [ Mac ] virtual/layout-ng-grid/external/wpt/css/css-grid/alignment/grid-gutters-014.html [ Failure ]
......
third_party/blink/web_tests/external/wpt/payment-request/payment-is-showing.https.html
View file @ 9e80a88e
......@@ -7,8 +7,8 @@
<meta name="timeout" content="long">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<body>
<script>
"use strict";
......
third_party/blink/web_tests/external/wpt/payment-request/payment-request-canmakepayment-method-protection.https-expected.txt
View file @ 9e80a88e
This is a testharness.js-based test.
Harness Error. harness_status.status = 1 , harness_status.message = Uncaught TypeError: Cannot set property 'click' of undefined
FAIL Optionally, at the user agent's discretion, return a promise rejected with a "NotAllowedError" DOMException. assert_equals: if it throws, then it must be a NotAllowedError. expected "NotAllowedError" but got "UnknownError"
Harness: the test ran to completion.
third_party/blink/web_tests/external/wpt/payment-request/payment-request-canmakepayment-method-protection.https.html
View file @ 9e80a88e
......@@ -4,8 +4,8 @@
<link rel="help" href="https://w3c.github.io/browser-payment-api/#show-method">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src='/resources/testdriver-vendor.js'></script>
<script src="/resources/testdriver.js"></script>
<script src='/resources/testdriver-vendor.js'></script>
<script>
const basicCard = Object.freeze({ supportedMethods: "basic-card" });
const applePay = Object.freeze({
......
third_party/blink/web_tests/external/wpt/web-share/share-consume-activation.https-expected.txt deleted 100644 → 0
View file @ 26aef835
This is a testharness.js-based test.
Harness Error. harness_status.status = 1 , harness_status.message = Uncaught TypeError: Cannot set property 'click' of undefined
Harness: the test ran to completion.
third_party/blink/web_tests/external/wpt/web-share/share-consume-activation.https.html
View file @ 9e80a88e
......@@ -6,8 +6,8 @@
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/manual-helper.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
</head>
<body>
<script>
......
third_party/blink/web_tests/external/wpt/web-share/share-empty.https-expected.txt deleted 100644 → 0
View file @ 26aef835
This is a testharness.js-based test.
Harness Error. harness_status.status = 1 , harness_status.message = Uncaught TypeError: Cannot set property 'click' of undefined
Harness: the test ran to completion.
third_party/blink/web_tests/external/wpt/web-share/share-empty.https.html
View file @ 9e80a88e
......@@ -6,8 +6,8 @@
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="resources/manual-helper.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
</head>
<body>
<script>
......
third_party/blink/web_tests/external/wpt/web-share/share-url-invalid.https-expected.txt deleted 100644 → 0
View file @ 26aef835
This is a testharness.js-based test.
Harness Error. harness_status.status = 1 , harness_status.message = Uncaught TypeError: Cannot set property 'click' of undefined
Harness: the test ran to completion.
third_party/blink/web_tests/external/wpt/web-share/share-url-invalid.https.html
View file @ 9e80a88e
......@@ -5,8 +5,8 @@
<title>WebShare Test: Share with an invalid URL</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
</head>
<body>
<script>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment