Chrome style plugin: enable virtual specifier checks for Gmock objects in //google_apis/gaia.

Previously, the plugin completely skipped virtual specifier checks on
Gmock objects since it wasn't smart enough to filter out warnings caused
by Gmock macros. In preparation for making the plugin smarter, this CL
fixes existing virtual specifier warnings in //google_apis/gaia.

This CL was uploaded by git cl split.

R=rogerta@chromium.org

Bug: 837148
Change-Id: Ia35de72ebe190980cbce1b3a8b0e96bd7f6fa246
Reviewed-on: https://chromium-review.googlesource.com/1031198Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554833}

google_apis/gaia/gaia_auth_fetcher_unittest.cc

@@ -171,7 +171,7 @@ class GaiaAuthFetcherTest : public testing::Test {
 class MockGaiaConsumer : public GaiaAuthConsumer {
  public:
   MockGaiaConsumer() {}
-  ~MockGaiaConsumer() {}
+  ~MockGaiaConsumer() override {}
 
   MOCK_METHOD1(OnClientLoginSuccess, void(const ClientLoginResult& result));
   MOCK_METHOD2(OnIssueAuthTokenSuccess, void(const std::string& service,

google_apis/gaia/gaia_oauth_client_unittest.cc

@@ -205,7 +205,7 @@ class GaiaOAuthClientTest : public testing::Test {
 class MockGaiaOAuthClientDelegate : public gaia::GaiaOAuthClient::Delegate {
  public:
   MockGaiaOAuthClientDelegate() {}
-  ~MockGaiaOAuthClientDelegate() {}
+  ~MockGaiaOAuthClientDelegate() override {}
 
   MOCK_METHOD3(OnGetTokensResponse, void(const std::string& refresh_token,
                                          const std::string& access_token,

google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc

@@ -64,7 +64,7 @@ class MockUrlFetcherFactory : public ScopedURLFetcherFactory,
                               public URLFetcherFactory {
  public:
   MockUrlFetcherFactory() : ScopedURLFetcherFactory(this) {}
-  virtual ~MockUrlFetcherFactory() {}
+  ~MockUrlFetcherFactory() override {}
 
   MOCK_METHOD5(
       CreateURLFetcherMock,
@@ -88,7 +88,7 @@ class MockUrlFetcherFactory : public ScopedURLFetcherFactory,
 class MockOAuth2AccessTokenConsumer : public OAuth2AccessTokenConsumer {
  public:
   MockOAuth2AccessTokenConsumer() {}
-  ~MockOAuth2AccessTokenConsumer() {}
+  ~MockOAuth2AccessTokenConsumer() override {}
 
   MOCK_METHOD2(OnGetTokenSuccess,
                void(const std::string& access_token,

google_apis/gaia/oauth2_api_call_flow_unittest.cc

@@ -63,7 +63,7 @@ class MockUrlFetcherFactory : public ScopedURLFetcherFactory,
   MockUrlFetcherFactory()
       : ScopedURLFetcherFactory(this) {
   }
-  virtual ~MockUrlFetcherFactory() {}
+  ~MockUrlFetcherFactory() override {}
 
   MOCK_METHOD5(CreateURLFetcherMock,
                std::unique_ptr<URLFetcher>(
@@ -86,7 +86,7 @@ class MockUrlFetcherFactory : public ScopedURLFetcherFactory,
 class MockApiCallFlow : public OAuth2ApiCallFlow {
  public:
   MockApiCallFlow() {}
-  ~MockApiCallFlow() {}
+  ~MockApiCallFlow() override {}
 
   MOCK_METHOD0(CreateApiCallUrl, GURL());
   MOCK_METHOD0(CreateApiCallBody, std::string());
@@ -96,7 +96,8 @@ class MockApiCallFlow : public OAuth2ApiCallFlow {
   MOCK_METHOD1(ProcessMintAccessTokenFailure,
                void(const GoogleServiceAuthError& error));
 
-  net::PartialNetworkTrafficAnnotationTag GetNetworkTrafficAnnotationTag() {
+  net::PartialNetworkTrafficAnnotationTag GetNetworkTrafficAnnotationTag()
+      override {
     return PARTIAL_TRAFFIC_ANNOTATION_FOR_TESTS;
   }
 };

google_apis/gaia/oauth2_mint_token_flow_unittest.cc

@@ -128,7 +128,7 @@ static IssueAdviceInfo CreateIssueAdvice() {
 class MockDelegate : public OAuth2MintTokenFlow::Delegate {
  public:
   MockDelegate() {}
-  ~MockDelegate() {}
+  ~MockDelegate() override {}
 
   MOCK_METHOD2(OnMintTokenSuccess, void(const std::string& access_token,
                                         int time_to_live));
@@ -143,7 +143,7 @@ class MockMintTokenFlow : public OAuth2MintTokenFlow {
   explicit MockMintTokenFlow(MockDelegate* delegate,
                              const OAuth2MintTokenFlow::Parameters& parameters)
       : OAuth2MintTokenFlow(delegate, parameters) {}
-  ~MockMintTokenFlow() {}
+  ~MockMintTokenFlow() override {}
 
   MOCK_METHOD0(CreateAccessTokenFetcher, OAuth2AccessTokenFetcher*());
 };
@@ -153,7 +153,7 @@ class MockMintTokenFlow : public OAuth2MintTokenFlow {
 class OAuth2MintTokenFlowTest : public testing::Test {
  public:
   OAuth2MintTokenFlowTest() {}
-  virtual ~OAuth2MintTokenFlowTest() { }
+  ~OAuth2MintTokenFlowTest() override {}
 
  protected:
   void CreateFlow(OAuth2MintTokenFlow::Mode mode) {