Commit 9ec828c0 authored by Anne Lim's avatar Anne Lim Committed by Chromium LUCI CQ

[AF] Fix StrikeDatabase test

I forgot to set expiry_time_micros_, but it passed the unittest
because I also forgot to call RemoveExpiredStrikes() in the unittest.

Bug: 1061639
Change-Id: I80570e03202c22cca069cb2084351849a4979484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594313Reviewed-by: default avatarJared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#837419}
parent 10fd64d4
...@@ -62,6 +62,8 @@ class StrikeDatabaseIntegratorBase { ...@@ -62,6 +62,8 @@ class StrikeDatabaseIntegratorBase {
private: private:
FRIEND_TEST_ALL_PREFIXES(ChromeBrowsingDataRemoverDelegateTest, FRIEND_TEST_ALL_PREFIXES(ChromeBrowsingDataRemoverDelegateTest,
StrikeDatabaseEmptyOnAutofillRemoveEverything); StrikeDatabaseEmptyOnAutofillRemoveEverything);
FRIEND_TEST_ALL_PREFIXES(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
NonExpiringStrikesDoNotExpire);
FRIEND_TEST_ALL_PREFIXES(StrikeDatabaseIntegratorTestStrikeDatabaseTest, FRIEND_TEST_ALL_PREFIXES(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
RemoveExpiredStrikesTest); RemoveExpiredStrikesTest);
FRIEND_TEST_ALL_PREFIXES(StrikeDatabaseIntegratorTestStrikeDatabaseTest, FRIEND_TEST_ALL_PREFIXES(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
......
...@@ -15,7 +15,9 @@ StrikeDatabaseIntegratorTestStrikeDatabase:: ...@@ -15,7 +15,9 @@ StrikeDatabaseIntegratorTestStrikeDatabase::
StrikeDatabaseIntegratorTestStrikeDatabase( StrikeDatabaseIntegratorTestStrikeDatabase(
StrikeDatabase* strike_database, StrikeDatabase* strike_database,
base::Optional<int64_t> expiry_time_micros) base::Optional<int64_t> expiry_time_micros)
: StrikeDatabaseIntegratorTestStrikeDatabase(strike_database) {} : StrikeDatabaseIntegratorTestStrikeDatabase(strike_database) {
expiry_time_micros_ = expiry_time_micros;
}
StrikeDatabaseIntegratorTestStrikeDatabase:: StrikeDatabaseIntegratorTestStrikeDatabase::
StrikeDatabaseIntegratorTestStrikeDatabase(StrikeDatabase* strike_database) StrikeDatabaseIntegratorTestStrikeDatabase(StrikeDatabase* strike_database)
......
...@@ -127,6 +127,8 @@ TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest, ...@@ -127,6 +127,8 @@ TEST_F(StrikeDatabaseIntegratorTestStrikeDatabaseTest,
// Advance clock very far into the future. // Advance clock very far into the future.
test_clock.Advance(base::TimeDelta::FromDays(INT_MAX)); test_clock.Advance(base::TimeDelta::FromDays(INT_MAX));
no_expiry_strike_database_->RemoveExpiredStrikes();
// Strike should not be removed. // Strike should not be removed.
EXPECT_EQ(1, no_expiry_strike_database_->GetStrikes()); EXPECT_EQ(1, no_expiry_strike_database_->GetStrikes());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment