Commit 9ecc8645 authored by shreyasv's avatar shreyasv Committed by Commit bot

Removing WKWebViewSearchParam

This is no longer needed.

BUG=579249

Review URL: https://codereview.chromium.org/1609293003

Cr-Commit-Position: refs/heads/master@{#370717}
parent 5a0cceea
...@@ -64,10 +64,6 @@ std::string SearchTermsData::ForceInstantResultsParam( ...@@ -64,10 +64,6 @@ std::string SearchTermsData::ForceInstantResultsParam(
return std::string(); return std::string();
} }
std::string SearchTermsData::IOSWebViewTypeParam() const {
return std::string();
}
std::string SearchTermsData::GoogleImageSearchSource() const { std::string SearchTermsData::GoogleImageSearchSource() const {
return std::string(); return std::string();
} }
......
...@@ -56,11 +56,6 @@ class SearchTermsData { ...@@ -56,11 +56,6 @@ class SearchTermsData {
// incrementally. // incrementally.
virtual std::string ForceInstantResultsParam(bool for_prerender) const; virtual std::string ForceInstantResultsParam(bool for_prerender) const;
// Returns a string indicating which webview is currently in use on iOS,
// suitable for adding as a query string param to search requests. Returns an
// empty string if no parameter should be passed along with search requests.
virtual std::string IOSWebViewTypeParam() const;
// Returns the value to use for replacements of type // Returns the value to use for replacements of type
// GOOGLE_IMAGE_SEARCH_SOURCE. // GOOGLE_IMAGE_SEARCH_SOURCE.
virtual std::string GoogleImageSearchSource() const; virtual std::string GoogleImageSearchSource() const;
......
...@@ -40,10 +40,6 @@ bool IsTargetedToWKWebViewExperimentControlGroup(); ...@@ -40,10 +40,6 @@ bool IsTargetedToWKWebViewExperimentControlGroup();
// Whether the user is part of a control group for the WKWebView experiment. // Whether the user is part of a control group for the WKWebView experiment.
bool IsInWKWebViewExperimentControlGroup(); bool IsInWKWebViewExperimentControlGroup();
// Returns a string containing extra params that should be sent along with
// omnibox search requests. The returned value contains a leading "&".
std::string GetWKWebViewSearchParams();
// Whether viewing and copying passwords is enabled. // Whether viewing and copying passwords is enabled.
bool IsViewCopyPasswordsEnabled(); bool IsViewCopyPasswordsEnabled();
......
...@@ -184,14 +184,6 @@ bool IsInWKWebViewExperimentControlGroup() { ...@@ -184,14 +184,6 @@ bool IsInWKWebViewExperimentControlGroup() {
base::CompareCase::INSENSITIVE_ASCII); base::CompareCase::INSENSITIVE_ASCII);
} }
std::string GetWKWebViewSearchParams() {
if (!CanCheckWKWebViewExperiment()) {
return std::string();
}
return variations::GetVariationParamValue(kWKWebViewTrialName, "esrch");
}
bool IsViewCopyPasswordsEnabled() { bool IsViewCopyPasswordsEnabled() {
NSString* viewCopyPasswordFlag = [[NSUserDefaults standardUserDefaults] NSString* viewCopyPasswordFlag = [[NSUserDefaults standardUserDefaults]
objectForKey:kEnableViewCopyPasswords]; objectForKey:kEnableViewCopyPasswords];
......
...@@ -103,16 +103,6 @@ std::string UIThreadSearchTermsData::ForceInstantResultsParam( ...@@ -103,16 +103,6 @@ std::string UIThreadSearchTermsData::ForceInstantResultsParam(
return search::ForceInstantResultsParam(for_prerender); return search::ForceInstantResultsParam(for_prerender);
} }
std::string UIThreadSearchTermsData::IOSWebViewTypeParam() const {
DCHECK(thread_checker_.CalledOnValidThread());
std::string param = experimental_flags::GetWKWebViewSearchParams();
if (param.empty()) {
return std::string();
}
return "&esrch=" + net::EscapeQueryParamValue(param, true);
}
std::string UIThreadSearchTermsData::GoogleImageSearchSource() const { std::string UIThreadSearchTermsData::GoogleImageSearchSource() const {
DCHECK(thread_checker_.CalledOnValidThread()); DCHECK(thread_checker_.CalledOnValidThread());
std::string version(version_info::GetProductName() + " " + std::string version(version_info::GetProductName() + " " +
......
...@@ -28,7 +28,6 @@ class UIThreadSearchTermsData : public SearchTermsData { ...@@ -28,7 +28,6 @@ class UIThreadSearchTermsData : public SearchTermsData {
std::string GetSuggestRequestIdentifier() const override; std::string GetSuggestRequestIdentifier() const override;
std::string InstantExtendedEnabledParam(bool for_search) const override; std::string InstantExtendedEnabledParam(bool for_search) const override;
std::string ForceInstantResultsParam(bool for_prerender) const override; std::string ForceInstantResultsParam(bool for_prerender) const override;
std::string IOSWebViewTypeParam() const override;
std::string GoogleImageSearchSource() const override; std::string GoogleImageSearchSource() const override;
private: private:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment