Create a new flag for omnibox shortcuts experiment.

Bug: 884675
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9a7ac9b2cd525d976a3e5d5644004067cdb9d982
Reviewed-on: https://chromium-review.googlesource.com/1228056
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592374}

ios/chrome/browser/about_flags.mm

@@ -384,6 +384,9 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
     {"toolbar-container", flag_descriptions::kToolbarContainerName,
      flag_descriptions::kToolbarContainerDescription, flags_ui::kOsIos,
      FEATURE_VALUE_TYPE(toolbar_container::kToolbarContainerEnabled)},
+    {"omnibox-popup-shortcuts", flag_descriptions::kOmniboxPopupShortcutsName,
+     flag_descriptions::kOmniboxPopupShortcutsDescription, flags_ui::kOsIos,
+     FEATURE_VALUE_TYPE(kOmniboxPopupShortcuts)},
     {"sso-with-wkwebview", flag_descriptions::kSSOWithWKWebViewName,
      flag_descriptions::kSSOWithWKWebViewDescription, flags_ui::kOsIos,
      FEATURE_VALUE_TYPE(kSSOWithWKWebView)},

ios/chrome/browser/ios_chrome_flag_descriptions.cc

@@ -208,6 +208,11 @@ const char kNewPasswordFormParsingDescription[] =
     "currently under development. WARNING: when enabled Password Manager might "
     "stop working";
 
+const char kOmniboxPopupShortcutsName[] = "Show zero-state omnibox shortcuts";
+const char kOmniboxPopupShortcutsDescription[] =
+    "Instead of ZeroSuggest, show most visited sites and collection shortcuts "
+    "in the omnibox popup.";
+
 const char kOmniboxUIElideSuggestionUrlAfterHostName[] =
     "Hide the path, query, and ref of omnibox suggestions";
 const char kOmniboxUIElideSuggestionUrlAfterHostDescription[] =

ios/chrome/browser/ios_chrome_flag_descriptions.h

@@ -170,6 +170,11 @@ extern const char kMemexTabSwitcherDescription[];
 extern const char kNewPasswordFormParsingName[];
 extern const char kNewPasswordFormParsingDescription[];
 
+// Title and description for the flag to show most visited sites and collection
+// shortcuts in the omnibox popup instead of ZeroSuggest.
+extern const char kOmniboxPopupShortcutsName[];
+extern const char kOmniboxPopupShortcutsDescription[];
+
 // Title and description for the flag to enable elision of the URL path, query,
 // and ref in omnibox URL suggestions.
 extern const char kOmniboxUIElideSuggestionUrlAfterHostName[];

ios/chrome/browser/ui/ui_feature_flags.cc

@@ -9,5 +9,7 @@ const base::Feature kFirstResponderKeyWindow{"FirstResponderKeyWindow",
 
 const base::Feature kCopyImage{"CopyImage", base::FEATURE_ENABLED_BY_DEFAULT};
 
+const base::Feature kOmniboxPopupShortcuts{"OmniboxPopupShortcuts",
+                                           base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kWKWebViewSnapshots{"WKWebViewSnapshots",
                                         base::FEATURE_DISABLED_BY_DEFAULT};

ios/chrome/browser/ui/ui_feature_flags.h

@@ -15,6 +15,10 @@ extern const base::Feature kFirstResponderKeyWindow;
 // Feature to copy image to system pasteboard via context menu.
 extern const base::Feature kCopyImage;
 
+// Feature to show most visited sites and collection shortcuts in the omnibox
+// popup instead of ZeroSuggest.
+extern const base::Feature kOmniboxPopupShortcuts;
+
 // Used to enable using the WKWebView snapshotting API for iOS 11+.
 extern const base::Feature kWKWebViewSnapshots;