MacViews: Push VSync parameters from RHWVMac to BridgedNativeView
This is not an appropriate long-term solution, but is a solution that has a minimal diff and can be merged fairly easily. The appropriate fix is to: - make BridgedNativeView have a DisplayLink - update that DisplayLink when the NSWindow is moved between monitors - ensure that the VSync parameters are updated "reasonably frequently" to avoid skew - RWHVMac will poke the DisplayLink every time the renderer displays a new frame - at each poke, the DisplayLink will update its parameters if it has not done so in the last 10 seconds - this scheme will need to be revisited both for BridgedNativeView (because it rarely gets new frames compared to the renderer) and for OOP-D (because RWHVMac will no longer be informed of frames) Such a fix is a bigger undertaking than should be merged to a branch, so just push the VSync parameters from RWHVMac (that we would ordinarly send to the web-contents-only ui::Compositor) to the parent ui::Layer's compositor instead. This will only "fix" windows that have web contents in them (which is almost everything that will have an animation). Bug: 869129 Change-Id: Ie5949798aa4d1f42e73197326bca5e6e574f0843 Reviewed-on: https://chromium-review.googlesource.com/1157027Reviewed-by:Trent Apted <tapted@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#579712}
Showing
Please register or sign in to comment