Commit 9ef21552 authored by eroman's avatar eroman Committed by Commit bot

Improve documentation of CertVerifier::Verify() regarding |out_req|.

Also adds DISALLOW_COPY() to Request.

BUG=475153

Review URL: https://codereview.chromium.org/1131173005

Cr-Commit-Position: refs/heads/master@{#330840}
parent a9adafea
...@@ -25,8 +25,13 @@ class NET_EXPORT CertVerifier { ...@@ -25,8 +25,13 @@ class NET_EXPORT CertVerifier {
public: public:
class Request { class Request {
public: public:
Request() {}
// Destruction of the Request cancels it. // Destruction of the Request cancels it.
virtual ~Request() {} virtual ~Request() {}
private:
DISALLOW_COPY_AND_ASSIGN(Request);
}; };
enum VerifyFlags { enum VerifyFlags {
...@@ -99,8 +104,13 @@ class NET_EXPORT CertVerifier { ...@@ -99,8 +104,13 @@ class NET_EXPORT CertVerifier {
// could not be completed synchronously, in which case the result code will // could not be completed synchronously, in which case the result code will
// be passed to the callback when available. // be passed to the callback when available.
// //
// |*out_req| will be filled with a pointer to the asynchronous request. // On asynchronous completion (when Verify returns ERR_IO_PENDING) |out_req|
// Freeing this pointer before the request has completed will cancel it. // will be reset with a pointer to the request. Freeing this pointer before
// the request has completed will cancel it.
//
// If Verify() completes synchronously then |out_req| *may* be reset to
// nullptr. However it is not guaranteed that all implementations will reset
// it in this case.
// //
// TODO(rsleevi): Move CRLSet* out of the CertVerifier signature. // TODO(rsleevi): Move CRLSet* out of the CertVerifier signature.
virtual int Verify(X509Certificate* cert, virtual int Verify(X509Certificate* cert,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment