Commit 9ef9d8e8 authored by dpranke's avatar dpranke Committed by Commit bot

Fix MB configs for public PGO builders.

The public PGO builders do not do chrome-branded builds, so
can't reuse the existing 'official' mixin and need to split out
is_official_build from is_chrome_branded.

TBR=sebmarchand@chromium.org
NOTRY=true
BUG=595947

Review-Url: https://codereview.chromium.org/2180513002
Cr-Commit-Position: refs/heads/master@{#407230}
parent 81de3420
...@@ -117,12 +117,12 @@ ...@@ -117,12 +117,12 @@
'Chromium Mac 10.9 Goma Canary (dbg)': 'gn_debug_bot', 'Chromium Mac 10.9 Goma Canary (dbg)': 'gn_debug_bot',
'Chromium Mac 10.9 Goma Canary (dbg)(clobber)': 'gn_debug_bot', 'Chromium Mac 10.9 Goma Canary (dbg)(clobber)': 'gn_debug_bot',
'Chromium Win PGO Builder': [ 'Chromium Win PGO Builder': [
'gyp_official_chrome_pgo_phase_1_x86', 'gyp_official_optimize_chrome_pgo_phase_1_x86',
'gyp_official_chrome_pgo_phase_2_x86' 'gyp_official_optimize_chrome_pgo_phase_2_x86'
], ],
'Chromium Win x64 PGO Builder': [ 'Chromium Win x64 PGO Builder': [
'gyp_official_chrome_pgo_phase_1_x64', 'gyp_official_optimize_chrome_pgo_phase_1_x64',
'gyp_official_chrome_pgo_phase_2_x64', 'gyp_official_optimize_chrome_pgo_phase_2_x64',
], ],
'Chromium Windows Analyze': 'gn_windows_analyze', 'Chromium Windows Analyze': 'gn_windows_analyze',
'CrWin7Goma': 'gn_release_bot_minimal_symbols_x86', 'CrWin7Goma': 'gn_release_bot_minimal_symbols_x86',
...@@ -922,8 +922,8 @@ ...@@ -922,8 +922,8 @@
'win_optional_gpu_tests_rel': 'win_optional_gpu_tests_rel':
'swarming_gpu_tests_deqp_gles_gn_release_trybot_x86', 'swarming_gpu_tests_deqp_gles_gn_release_trybot_x86',
'win_pgo': [ 'win_pgo': [
'gyp_official_chrome_pgo_phase_1_x86', 'gyp_official_optimize_chrome_pgo_phase_1_x86',
'gyp_official_chrome_pgo_phase_2_x86', 'gyp_official_optimize_chrome_pgo_phase_2_x86',
], ],
'win_upload_clang': 'gn_release_bot', 'win_upload_clang': 'gn_release_bot',
'win_chrome_official': 'gn_official_goma_minimal_symbols_x86', 'win_chrome_official': 'gn_official_goma_minimal_symbols_x86',
...@@ -1377,7 +1377,23 @@ ...@@ -1377,7 +1377,23 @@
], ],
'gyp_official_chrome_pgo_phase_2_x86': [ 'gyp_official_chrome_pgo_phase_2_x86': [
'gyp', 'official', 'chrome_pgo_phase_2', 'x86', 'gyp', 'official_optimize', 'chrome_pgo_phase_2', 'x86',
],
'gyp_official_optimize_chrome_pgo_phase_1_x64': [
'gyp', 'official_optimize', 'chrome_pgo_phase_1', 'x64',
],
'gyp_official_optimize_chrome_pgo_phase_2_x64': [
'gyp', 'official_optimize', 'chrome_pgo_phase_2', 'x64',
],
'gyp_official_optimize_chrome_pgo_phase_1_x86': [
'gyp', 'official_optimize', 'chrome_pgo_phase_1', 'x86',
],
'gyp_official_optimize_chrome_pgo_phase_2_x86': [
'gyp', 'official_optimize', 'chrome_pgo_phase_2', 'x86',
], ],
'gyp_official_x64': [ 'gyp_official_x64': [
...@@ -2219,9 +2235,14 @@ ...@@ -2219,9 +2235,14 @@
}, },
'official': { 'official': {
'gn_args': ('is_chrome_branded=true is_official_build=true ' 'mixins': ['official_optimize'],
'is_debug=false'), 'gn_args': 'is_chrome_branded=true',
'gyp_defines': 'branding=Chrome buildtype=Official', 'gyp_defines': 'branding=Chrome',
},
'official_optimize': {
'gn_args': 'is_official_build=true is_debug=false',
'gyp_defines': 'buildtype=Official',
}, },
'ozone': { 'ozone': {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment