Commit 9f0fd8fc authored by Rob Buis's avatar Rob Buis Committed by Commit Bot

Add negative tests to SignedExchangeUtils unit test

Add negative tests to SignedExchangeUtils unit test to test
how we deal with questionable/wrong content types.

Bug: 803774

Change-Id: If726951a4fb96506251ad7fd1ac26a6940174e6c
Reviewed-on: https://chromium-review.googlesource.com/1203995Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#589495}
parent 129123b5
...@@ -9,6 +9,12 @@ ...@@ -9,6 +9,12 @@
namespace content { namespace content {
namespace signed_exchange_utils { namespace signed_exchange_utils {
TEST(SignedExchangeUtilsTest, VersionParam_WrongEssence) {
base::Optional<SignedExchangeVersion> version =
GetSignedExchangeVersion("application/signed-foo");
EXPECT_FALSE(version.has_value());
}
TEST(SignedExchangeUtilsTest, VersionParam_None) { TEST(SignedExchangeUtilsTest, VersionParam_None) {
base::Optional<SignedExchangeVersion> version = base::Optional<SignedExchangeVersion> version =
GetSignedExchangeVersion("application/signed-exchange"); GetSignedExchangeVersion("application/signed-exchange");
...@@ -63,6 +69,24 @@ TEST(SignedExchangeUtilsTest, VersionParam_Quoted) { ...@@ -63,6 +69,24 @@ TEST(SignedExchangeUtilsTest, VersionParam_Quoted) {
EXPECT_EQ(version, SignedExchangeVersion::kB2); EXPECT_EQ(version, SignedExchangeVersion::kB2);
} }
TEST(SignedExchangeUtilsTest, VersionParam_QuotesOpen) {
base::Optional<SignedExchangeVersion> version =
GetSignedExchangeVersion("application/signed-exchange;v=\"b2");
EXPECT_EQ(version, SignedExchangeVersion::kB2);
}
TEST(SignedExchangeUtilsTest, VersionParam_QuotesOpenNonV) {
base::Optional<SignedExchangeVersion> version =
GetSignedExchangeVersion("application/signed-exchange;v=\"b2;r=\"b2");
EXPECT_EQ(version, SignedExchangeVersion::kUnknown);
}
TEST(SignedExchangeUtilsTest, VersionParam_QuotesOpenNonV2) {
base::Optional<SignedExchangeVersion> version =
GetSignedExchangeVersion("application/signed-exchange;v=\"b2\";r=\"b2");
EXPECT_EQ(version, SignedExchangeVersion::kB2);
}
TEST(SignedExchangeUtilsTest, VersionParam_UseCaseInsensitiveMatch) { TEST(SignedExchangeUtilsTest, VersionParam_UseCaseInsensitiveMatch) {
base::Optional<SignedExchangeVersion> version = base::Optional<SignedExchangeVersion> version =
GetSignedExchangeVersion("Application/Signed-Exchange;V=b2"); GetSignedExchangeVersion("Application/Signed-Exchange;V=b2");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment