Commit 9f61b9ed authored by Jimmy Gong's avatar Jimmy Gong Committed by Commit Bot

Remove redundant checks in protocol dropdown in edit printer dialog

- It was redundant to disable a network protocol option when the
  dropdown was already disabled if there is no connectivity or
  is a USB printer.

Bug: 947183
Test: End to End manual, browsertests
Change-Id: Iff171ad14a2db8a2911357b3aa5225d6b5ded177
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748004
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarBailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688242}
parent d2764546
...@@ -59,22 +59,22 @@ ...@@ -59,22 +59,22 @@
on-change="onProtocolChange_" on-change="onProtocolChange_"
disabled="[[!protocolSelectEnabled(isOnline_, disabled="[[!protocolSelectEnabled(isOnline_,
networkProtocolActive_)]]"> networkProtocolActive_)]]">
<option value="ipp" disabled="[[!networkProtocolActive_]]"> <option value="ipp">
$i18n{printerProtocolIpp} $i18n{printerProtocolIpp}
</option> </option>
<option value="ipps" disabled="[[!networkProtocolActive_]]"> <option value="ipps">
$i18n{printerProtocolIpps} $i18n{printerProtocolIpps}
</option> </option>
<option value="http" disabled="[[!networkProtocolActive_]]"> <option value="http">
$i18n{printerProtocolHttp} $i18n{printerProtocolHttp}
</option> </option>
<option value="https" disabled="[[!networkProtocolActive_]]"> <option value="https">
$i18n{printerProtocolHttps} $i18n{printerProtocolHttps}
</option> </option>
<option value="socket" disabled="[[!networkProtocolActive_]]"> <option value="socket">
$i18n{printerProtocolAppSocket} $i18n{printerProtocolAppSocket}
</option> </option>
<option value="lpd" disabled="[[!networkProtocolActive_]]"> <option value="lpd">
$i18n{printerProtocolLpd} $i18n{printerProtocolLpd}
</option> </option>
<option value="usb" disabled="[[networkProtocolActive_]]"> <option value="usb" disabled="[[networkProtocolActive_]]">
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment