Commit 9f77846e authored by Yue Zhang's avatar Yue Zhang Committed by Commit Bot

Disable item animation for Duet-TabStrip Integration

Since fixes http://crrev.com/c/2036874 and http://crrev.com/c/2048988
don't eliminate all crashes caused by recycling detached item in popup
tab strip, this CL block the crashing path by disabling the item
animation for Duet-TabStrip integration to get rid of the crash.
Note that this CL is a band-aid fix in sacrifice of animation.

Bug: 1045944
Change-Id: I3301deed92e40f4fe2306d1ef1ff5ceadc3edbc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064453
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: default avatarWei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742752}
parent 84a28a5c
...@@ -209,6 +209,13 @@ public class TabListCoordinator implements Destroyable { ...@@ -209,6 +209,13 @@ public class TabListCoordinator implements Destroyable {
mRecyclerView.setAdapter(mAdapter); mRecyclerView.setAdapter(mAdapter);
mRecyclerView.setHasFixedSize(true); mRecyclerView.setHasFixedSize(true);
if (mMode == TabListMode.STRIP
&& CachedFeatureFlags.isDuetTabStripIntegrationAndroidEnabled()
&& CachedFeatureFlags.isBottomToolbarEnabled()) {
// TODO(crbug.com/1045944): Disable item animation for now for Duet-TabStrip Integration
// to avoid crash.
mRecyclerView.setItemAnimator(null);
}
if (recyclerListener != null) mRecyclerView.setRecyclerListener(recyclerListener); if (recyclerListener != null) mRecyclerView.setRecyclerListener(recyclerListener);
if (dynamicResourceLoader != null) { if (dynamicResourceLoader != null) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment