Commit 9f7ffae9 authored by Yuke Liao's avatar Yuke Liao Committed by Commit Bot

Revert "Fixed Navigation callbacks for failed provisional navigation."

This reverts commit 02bddfd9.

Reason for revert: NavigationCallbacksTest.FailedNavigation is failing on devices, and only devices, both iPhones and iPads with iOS 10 and iOS 11.

Original change's description:
> Fixed Navigation callbacks for failed provisional navigation.
> 
> Verified callbacks correctness with
> NavigationCallbacksTest.FailedNavigation integration test.
> 
> Before this CL DidStartNavigation was called twice (second time
> for presenting error in Native Content). DidFinishNavigation was
> called once (also for presenting NativeContent). First
> DidStartNavigation did not have a matching DidStartNavigation
> call.
> 
> This CL removes DidStartNavigation/DidFinishNavigation callbacks
> for for presenting error in Native Content and adds balanced
> DidFinishNavigation callback in handleLoadingError:.
> 
> Bug: 725241
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Id15ef8c9422e571f74f9c00bf88ea98ccbf6607c
> Reviewed-on: https://chromium-review.googlesource.com/758718
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517420}

TBR=eugenebut@chromium.org,kkhorimoto@chromium.org

Change-Id: I76bc2987780795fd72284b22203e945387f04c53
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 725241
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/777279Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517491}
parent cfa16769
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment