Commit 9f9bcea9 authored by Sylvain Defresne's avatar Sylvain Defresne Committed by Commit Bot

Remove set_sources_assignment_filter from //components/password_manager

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Bug: 1018739
Change-Id: I603a28a515baf49fcd72a9e7013a73a9c6b98aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414191
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807813}
parent 7a24bd92
...@@ -9,6 +9,12 @@ if (is_android) { ...@@ -9,6 +9,12 @@ if (is_android) {
import("//build/config/android/config.gni") import("//build/config/android/config.gni")
} }
# Reset sources_assignment_filter for the BUILD.gn file to prevent
# regression during the migration of Chromium away from the feature.
# See docs/no_sources_assignment_filter.md for more information.
# TODO(crbug.com/1018739): remove this when migration is done.
set_sources_assignment_filter([])
# TODO(crbug.com/1006430): Fix password reuse detection not fully functional on # TODO(crbug.com/1006430): Fix password reuse detection not fully functional on
# Android. # Android.
password_reuse_detection_support = !is_ios password_reuse_detection_support = !is_ios
...@@ -124,9 +130,6 @@ static_library("browser") { ...@@ -124,9 +130,6 @@ static_library("browser") {
"leak_detection_dialog_utils.h", "leak_detection_dialog_utils.h",
"login_database.cc", "login_database.cc",
"login_database.h", "login_database.h",
"login_database_ios.cc",
"login_database_mac.cc",
"login_database_win.cc",
"manage_passwords_referrer.h", "manage_passwords_referrer.h",
"multi_store_form_fetcher.cc", "multi_store_form_fetcher.cc",
"multi_store_form_fetcher.h", "multi_store_form_fetcher.h",
...@@ -339,13 +342,22 @@ static_library("browser") { ...@@ -339,13 +342,22 @@ static_library("browser") {
sources += [ "login_database_posix.cc" ] sources += [ "login_database_posix.cc" ]
} }
if (is_mac && !is_ios) { if (is_mac) {
sources += [ sources += [
"login_database_mac.cc",
"password_recovery_util_mac.cc", "password_recovery_util_mac.cc",
"password_recovery_util_mac.h", "password_recovery_util_mac.h",
] ]
} }
if (is_ios) {
sources += [ "login_database_ios.cc" ]
}
if (is_win) {
sources += [ "login_database_win.cc" ]
}
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations. # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment