Fix VideoFramePump to send keep-alive packets only after the first real frame.

Many ClientSession unittests assume that the first video frame always
contains video dimensions. When running under valgrind the keep-alive timer
may fire before the first video frame is sent and this breaks the tests.

Fixed VideoFramePump to start sending keep-alive messages only after the
first real frame is sent. Also made the keep-alive timer non-repeating.
This ensures that the pump doesn't try sending a keep-alive message until
the previous one has been sent.

BUG=458691

Review URL: https://codereview.chromium.org/936553003

Cr-Commit-Position: refs/heads/master@{#316933}

remoting/host/client_session_unittest.cc

@@ -384,7 +384,7 @@ TEST_F(ClientSessionTest, ClipboardStubFilter) {
 
   ConnectClientSession();
 
-  // With for the first frame.
+  // Wait for the first frame.
   run_loop.Run();
 
   // Inject test events that are expected to be injected.
@@ -445,8 +445,7 @@ TEST_F(ClientSessionTest, ClipboardStubFilter) {
   client_session_.reset();
 }
 
-// crbug.com/458691
-TEST_F(ClientSessionTest, DISABLED_LocalInputTest) {
+TEST_F(ClientSessionTest, LocalInputTest) {
   CreateClientSession();
 
   protocol::MouseEvent mouse_event1;
@@ -502,8 +501,7 @@ TEST_F(ClientSessionTest, DISABLED_LocalInputTest) {
   ConnectClientSession();
 }
 
-// crbug.com/458691
-TEST_F(ClientSessionTest, DISABLED_RestoreEventState) {
+TEST_F(ClientSessionTest, RestoreEventState) {
   CreateClientSession();
 
   protocol::KeyEvent key1;
@@ -559,8 +557,7 @@ TEST_F(ClientSessionTest, DISABLED_RestoreEventState) {
   ConnectClientSession();
 }
 
-// crbug.com/458691
-TEST_F(ClientSessionTest, DISABLED_ClampMouseEvents) {
+TEST_F(ClientSessionTest, ClampMouseEvents) {
   CreateClientSession();
 
   Expectation authenticated =

remoting/host/video_frame_pump.cc

@@ -60,7 +60,12 @@ VideoFramePump::VideoFramePump(
       capturer_(capturer.Pass()),
       encoder_(encoder.Pass()),
       video_stub_(video_stub),
-      keep_alive_timer_(true, true),
+      keep_alive_timer_(
+          FROM_HERE,
+          base::TimeDelta::FromMilliseconds(kKeepAlivePacketIntervalMs),
+          base::Bind(&VideoFramePump::SendKeepAlivePacket,
+                     base::Unretained(this)),
+          false),
       capture_scheduler_(base::Bind(&VideoFramePump::CaptureNextFrame,
                                     base::Unretained(this))),
       latest_event_timestamp_(0),
@@ -70,10 +75,6 @@ VideoFramePump::VideoFramePump(
 
   capturer_->Start(this);
   capture_scheduler_.Start();
-
-  keep_alive_timer_.Start(
-      FROM_HERE, base::TimeDelta::FromMilliseconds(kKeepAlivePacketIntervalMs),
-      base::Bind(&VideoFramePump::SendKeepAlivePacket, base::Unretained(this)));
 }
 
 VideoFramePump::~VideoFramePump() {

tools/valgrind/gtest_exclude/remoting_unittests.gtest.txt

 # http://crbug.com/241856
 VideoSchedulerTest.StartAndStop
-
-# crbug.com/458691
-ClientSessionTest.ClipboardStubFilter