Skip to content

GitLab

T
tangled
Commit 9fb1c9df authored by ap@webkit.org's avatar ap@webkit.org
Browse files
Options

Reviewed by Adele Peterson. 

        <rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail

        Test: http/tests/history/back-to-post.php

        * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
        Apply a new cache policy if it changed after the platform request was first created.
        While at it, also made sure to update timeout.



git-svn-id: svn://svn.chromium.org/blink/trunk@42785 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 5ecf0bfd
Hide whitespace changes
Inline Side-by-side
Showing with 76 additions and 0 deletions
third_party/WebKit/LayoutTests/ChangeLog
View file @ 9fb1c9df
2009-04-23 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Adele Peterson.
<rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail
* http/tests/history/back-to-post-expected.txt: Added.
* http/tests/history/back-to-post.php: Added.
2009-04-23 Adam Roben <aroben@apple.com> 2009-04-23 Adam Roben <aroben@apple.com>
Skip a newly-added test that fails on Windows Skip a newly-added test that fails on Windows
......
third_party/WebKit/LayoutTests/http/tests/history/back-to-post-expected.txt 0 → 100644
View file @ 9fb1c9df
main frame - has 1 onunload handler(s)
main frame - has 1 onunload handler(s)
main frame "finish" - has 1 onunload handler(s)
main frame - has 1 onunload handler(s)
Test for rdar://problem/6791439 Getting an error page instead of login page navigating back in gmail.
PASS
third_party/WebKit/LayoutTests/http/tests/history/back-to-post.php 0 → 100644
View file @ 9fb1c9df
<?php
header("Cache-control: no-cache, no-store");
header("Pragma: no-cache");
?>
<html>
<body>
<p>Test for <a href="rdar://problem/6791439">rdar://problem/6791439</a>
Getting an error page instead of login page navigating back in gmail.</p>
<div id="result">FAIL: Script did not run</div>
<form action="back-to-post.php?1" method="post">
<input name="a" value="b">
<input id="mysubmit" type="submit" name="Submit" value="Submit">
</form>
<script>
if (window.layoutTestController) {
layoutTestController.dumpAsText();
layoutTestController.waitUntilDone();
}
// Disable b/f cache.
window.onunload = function() {}
if (document.location.search == "") {
window.name = ""; // Use window.name to communicate between steps.
document.forms[0].submit();
} else if (document.location.search == "?1") {
if (window.name == "finish") {
window.name = "";
document.getElementById("result").innerHTML = 'PASS';
if (window.layoutTestController)
layoutTestController.notifyDone();
} else {
document.forms[0].action = "?2";
document.forms[0].submit();
}
} else {
// Test that going back to form submission result works.
window.name = "finish";
history.back();
}
</script>
</body>
</html>
third_party/WebKit/WebCore/ChangeLog
View file @ 9fb1c9df
2009-04-23 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Adele Peterson.
<rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail
Test: http/tests/history/back-to-post.php
* platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
Apply a new cache policy if it changed after the platform request was first created.
While at it, also made sure to update timeout.
2009-04-23 Zan Dobersek <zandobersek@gmail.com> 2009-04-23 Zan Dobersek <zandobersek@gmail.com>
Reviewed by Gustavo Noronha. Reviewed by Gustavo Noronha.
third_party/WebKit/WebCore/platform/network/cf/ResourceRequestCFNet.cpp
View file @ 9fb1c9df
...@@ -101,6 +101,8 @@ void ResourceRequest::doUpdatePlatformRequest() ...@@ -101,6 +101,8 @@ void ResourceRequest::doUpdatePlatformRequest()
cfRequest = CFURLRequestCreateMutableCopy(0, m_cfRequest.get()); cfRequest = CFURLRequestCreateMutableCopy(0, m_cfRequest.get());
CFURLRequestSetURL(cfRequest, url.get()); CFURLRequestSetURL(cfRequest, url.get());
CFURLRequestSetMainDocumentURL(cfRequest, mainDocumentURL.get()); CFURLRequestSetMainDocumentURL(cfRequest, mainDocumentURL.get());
CFURLRequestSetCachePolicy(cfRequest, (CFURLRequestCachePolicy)cachePolicy());
CFURLRequestSetTimeoutInterval(cfRequest, timeoutInterval());
} else { } else {
cfRequest = CFURLRequestCreateMutable(0, url.get(), (CFURLRequestCachePolicy)cachePolicy(), timeoutInterval(), mainDocumentURL.get()); cfRequest = CFURLRequestCreateMutable(0, url.get(), (CFURLRequestCachePolicy)cachePolicy(), timeoutInterval(), mainDocumentURL.get());
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment