Commit 9fc2c04d authored by Meilin Wang's avatar Meilin Wang Committed by Commit Bot

[CrOS PhoneHub] Make |ContinueBrowsingChip| focusable.

This CL makes the |ContinueBrowsingChip| focusable during tab traversal
and adds a focus ring for it with a desired shape.

Screenshot: https://screenshot.googleplex.com/8FbCDLZShLMsSUe.png

BUG=1106937,1126208

Change-Id: I2aff8afe936de2b6861dd1568ae17200f3b34d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451323Reviewed-by: default avatarTim Song <tengs@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814419}
parent 1ee3c451
......@@ -10,8 +10,10 @@
#include "ash/style/ash_color_provider.h"
#include "ash/system/phonehub/phone_hub_tray.h"
#include "ash/system/status_area_widget.h"
#include "ash/system/unified/unified_system_tray_view.h"
#include "base/strings/utf_string_conversions.h"
#include "chromeos/components/multidevice/logging/logging.h"
#include "ui/views/controls/highlight_path_generator.h"
#include "ui/views/controls/image_view.h"
#include "ui/views/controls/label.h"
#include "ui/views/layout/box_layout.h"
......@@ -33,6 +35,14 @@ constexpr gfx::Size kTitleViewSize(100, 40);
ContinueBrowsingChip::ContinueBrowsingChip(
const chromeos::phonehub::BrowserTabsModel::BrowserTabMetadata& metadata)
: views::Button(this), url_(metadata.url) {
SetFocusBehavior(FocusBehavior::ALWAYS);
focus_ring()->SetColor(UnifiedSystemTrayView::GetFocusRingColor());
// Install this highlight path generator to set the desired shape for
// our focus ring.
views::InstallRoundRectHighlightPathGenerator(this, gfx::Insets(),
kTaskContinuationChipRadius);
auto* layout = SetLayoutManager(std::make_unique<views::BoxLayout>(
views::BoxLayout::Orientation::kVertical, kContinueBrowsingChipPadding,
kContinueBrowsingChipSpacing));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment